From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6W60IfuHDGm85CUAWB0awg (envelope-from ) for ; Thu, 06 Nov 2025 06:35:23 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UVIkyF5E; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 86E051E057; Thu, 06 Nov 2025 06:35:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8BDC91E057 for ; Thu, 06 Nov 2025 06:35:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2F44C385DC2E for ; Thu, 6 Nov 2025 11:35:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F44C385DC2E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UVIkyF5E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6439D385C6F3 for ; Thu, 6 Nov 2025 11:34:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6439D385C6F3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6439D385C6F3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762428887; cv=none; b=bJ5Q4QHY8RCy6o6SZio753aTG6oprBcjII4t25RaSV6Uod6KHq5cU4lwh3REU0e8SrXbDlHxwaZrfP64TUJhXLNNABaffBt3T9EABDAbk1dH2X2X0kMQFiczW0uK/oLWn3AgKzE+FUIBdMc/SVQkU7PvXLrlvGh4xYGyrN5uAvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762428887; c=relaxed/simple; bh=tBtCnYiIt7aqMkR3E+mXHjv+/Y4ykfzN8/7PQD7u0HY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZGyqTQ8skQiNxsYZ6B9Xj6t9YiqOTj9RnU8eYmasnkdYTBS+JT8g93Iiy4pK1swI+4nSQsJ4jcfDGwyumApuL7iusmtgYSs4+dZAWMDheL+OoWDjNxH/vuTLooeUrI85FASnpkkfDrFI6srSOkMgM6kV0L2MBSnyLr94H28J26s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6439D385C6F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762428887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pX0lhxaJxTqqBmbbznHZYFh6rMI3pkkzncaY1R5yTjI=; b=UVIkyF5EQhjT5vBMeyt08Qx575HXhUMW5TcydhVSxIvEgX+kNOOUFHOepJ4XpE44+Ssidp heNhggw8EGXOiIlMpytIO0Jl1bEIcReZkzQOR1X5gkw+IVbqfyjmi0uC7ptvkLyrqrfTfb jMQNKbqPiIEyA5u+Y/zVJH/xYAu6Ntc= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-nxSRDsCbPNGtlRJnB_bZqg-1; Thu, 06 Nov 2025 06:34:46 -0500 X-MC-Unique: nxSRDsCbPNGtlRJnB_bZqg-1 X-Mimecast-MFC-AGG-ID: nxSRDsCbPNGtlRJnB_bZqg_1762428885 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-78105c10afdso1155267b3a.1 for ; Thu, 06 Nov 2025 03:34:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762428885; x=1763033685; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pX0lhxaJxTqqBmbbznHZYFh6rMI3pkkzncaY1R5yTjI=; b=AtE7JldS5O2fMhGX4R3kQeSxrJCiClAW8xVKYZt3NsEbWnt5gOb8qe92ILMPu+7PgY YS2QWYbVs2pNi10tNmQOyD2qNuBDRh0wk1VUU9jSILzb1yv06HQfKnHIrd+bl5loTriU 42xxAKhRMOoyUTBlK5u1zgUTEe0kK7h0wiCzlLKWE76T764WwllS77r9oX7JW5T28dGY d8L7h9/AVkwZlA+wYP+ABHT+3dmE/Ld5hghg3ip9RKdR7Mck38yEsppYJH3fNyhuzcap by+i18woLAr6JZz83+crBOpzQk5ym+WsfJ7MZolFe+kaogDnXxtxNj/Q4t4P34HkSXfj nbVw== X-Forwarded-Encrypted: i=1; AJvYcCX8sbyqpE/Op5uYljRbXJRyQIDQs28uF+2An9UQVRBlxNWEyEgaQf9PhTM8/DyCWvGuPXmDwMfPLySQrA==@sourceware.org X-Gm-Message-State: AOJu0YykfG7p3tM+SPBzkUn4Zf5UEFEGrYGZdZzV8d3vavI3nLFlLPHk LH+WTKLGDW9pFZhByk2BXb5YpowrDX/FbhID28Ybg9TwdvvxmgAoLRBarX+bLB31bIBCyT6fV87 L2r1f6cXhHWb8Jn7vRL01tH1pWgATpVRwJfgBoF2hUxIxpxglDntm7mq+69YPwfw= X-Gm-Gg: ASbGnctybUVhlI1OhEFvxAwhHWqhMS94t71R/0owhVlqWluShAiVdPzddRqs99F49o6 gMKL57P74ou3T47EwtjQdGGY7gtwA/RivIarBvPuW15Dleaq8NogQx5oM8m1xQEW9LZTqz4Vm/7 HNXXXN3mT8JvORTy8jBOAktcJ3oFFABW87kW4ds0wdYPMB05zymnvw90ypY55as7p3/5HACp914 Wu4ociDjJDBeQvnhvA9S8SayCpeqf7MUSZ9isHYP4elAGBw5GqTUwAuavsUToIxrbayOgNJBvtw g0n2imR7J6nQ6A3ewpZKEqpq6enb3nIDlBGoFtmrKCPX9Gr1wA7G3HcYcRFjGdPOYzgamBApoAd ciQBFI2pGOJw= X-Received: by 2002:a05:6a00:cc4:b0:7a6:6e01:d257 with SMTP id d2e1a72fcca58-7ae1f293f38mr8672217b3a.18.1762428885099; Thu, 06 Nov 2025 03:34:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPJ7Os+ZCwrwxuWVkVQYRpjem2qVeEMfbAK1qM6Y3t75XrbhQ8/BtDPDgM/x0A8vRX7Wg2nQ== X-Received: by 2002:a05:6a00:cc4:b0:7a6:6e01:d257 with SMTP id d2e1a72fcca58-7ae1f293f38mr8672186b3a.18.1762428884674; Thu, 06 Nov 2025 03:34:44 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7af7fd59a58sm2537550b3a.21.2025.11.06.03.34.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Nov 2025 03:34:44 -0800 (PST) Message-ID: <427fd8dc-ffd6-495a-afbb-39c23055bb53@redhat.com> Date: Thu, 6 Nov 2025 08:34:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix command_classes name clash To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org References: <20251105225914.1492360-1-simon.marchi@polymtl.ca> From: Guinevere Larsen In-Reply-To: <20251105225914.1492360-1-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Xs1VFQ7Ych-8a4xRHYwj5xxIMvJwdJ1Y2pPvoG7HGmY_1762428885 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/5/25 7:59 PM, simon.marchi@polymtl.ca wrote: > From: Simon Marchi > > I currently see this build failure: > > CXX guile/scm-cmd.o > /home/simark/src/binutils-gdb/gdb/guile/scm-cmd.c:551:54: error: ‘const scheme_integer_constant command_classes []’ redeclared as different kind of entity > 551 | static const scheme_integer_constant command_classes[] = > | ^ > In file included from /home/simark/src/binutils-gdb/gdb/defs.h:63, > from : > /home/simark/src/binutils-gdb/gdb/command.h:71:42: note: previous declaration ‘using command_classes = class enum_flags’ > 71 | DEF_ENUM_FLAGS_TYPE (enum command_class, command_classes); > | ^~~~~~~~~~~~~~~ > /home/simark/src/binutils-gdb/gdb/../gdbsupport/enum-flags.h:58:9: note: in definition of macro ‘DEF_ENUM_FLAGS_TYPE’ > 58 | using flags_type = enum_flags; \ > | ^~~~~~~~~~ > > This looks like an unfortunate name clash. Fix it by renaming the > variable in scm-cmd.c. > > Change-Id: I226b052c28eb8d09fd6840337845a387cd818085 > --- oops, sorry about that, I disable guile on my build and didn't notice the name clash. I encourage you to push this! Reviewed-By: Guinevere Larsen > gdb/guile/scm-cmd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c > index d2172d986187..bfd11917df96 100644 > --- a/gdb/guile/scm-cmd.c > +++ b/gdb/guile/scm-cmd.c > @@ -548,7 +548,7 @@ gdbscm_parse_command_name (const char *name, > /* NOTREACHED */ > } > > -static const scheme_integer_constant command_classes[] = > +static const scheme_integer_constant scm_command_classes[] = > { > /* Note: alias and user are special; pseudo appears to be unused, > and there is no reason to expose tui, I think. */ > @@ -576,9 +576,9 @@ gdbscm_valid_command_class_p (int command_class) > { > int i; > > - for (i = 0; command_classes[i].name != NULL; ++i) > + for (i = 0; scm_command_classes[i].name != NULL; ++i) > { > - if (command_classes[i].value == command_class) > + if (scm_command_classes[i].value == command_class) > return 1; > } > > @@ -903,7 +903,7 @@ gdbscm_initialize_commands (void) > = gdbscm_make_smob_type (command_smob_name, sizeof (command_smob)); > scm_set_smob_print (command_smob_tag, cmdscm_print_command_smob); > > - gdbscm_define_integer_constants (command_classes, 1); > + gdbscm_define_integer_constants (scm_command_classes, 1); > gdbscm_define_functions (command_functions, 1); > > for (i = 0; i < N_COMPLETERS; ++i) > > base-commit: 1518f2e087d31997711fc7f4472ab382c24fa903 -- Cheers, Guinevere Larsen It/she