From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39155-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 24348 invoked by alias); 2 May 2005 19:23:18 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24336 invoked from network); 2 May 2005 19:23:15 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 2 May 2005 19:23:15 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j42JNEFH010003
	for <gdb-patches@sources.redhat.com>; Mon, 2 May 2005 15:23:15 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j42JNEO12699;
	Mon, 2 May 2005 15:23:14 -0400
Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j42JNCth021484;
	Mon, 2 May 2005 15:23:13 -0400
Message-ID: <42767E20.4050701@redhat.com>
Date: Mon, 02 May 2005 19:23:00 -0000
From: Michael Snyder <msnyder@redhat.com>
User-Agent: Mozilla Thunderbird  (X11/20050322)
MIME-Version: 1.0
To: Daniel Jacobowitz <drow@false.org>
CC: gdb-patches@sources.redhat.com
Subject: Re: [RFC] mips_abi_update, flush_cached_frames
References: <015a01c53655$98481cb0$8ca66b80@msnyder8600> <20050401010040.GA17642@nevyn.them.org> <20050501231655.GA14925@nevyn.them.org>
In-Reply-To: <20050501231655.GA14925@nevyn.them.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-05/txt/msg00058.txt.bz2

Daniel Jacobowitz wrote:
> On Thu, Mar 31, 2005 at 08:00:40PM -0500, Daniel Jacobowitz wrote:
> 
>>On Thu, Mar 31, 2005 at 04:56:05PM -0800, Michael Snyder wrote:
>>
>>>Check me out here -- if you change the abi, it seems to me
>>>you better make sure you get rid of any cached frames...
>>>
>>>2005-03-31  msnyder  <msnyder@redhat.com>
>>>
>>>* mips-tdep.c (mips_abi_update): If abi is changed, cached
>>>frames better be flushed.
>>
>>Yes and no - I don't think this is the right place to do it.
>>My current feeling is that this belongs in
>>deprecated_current_gdbarch_select_hack.
>>
>>[You're definitely right about the problem, though.  I ran into this on
>>ARM last week.]
> 
> 
> I've committed this more general fix.

Thanks Daniel.