From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id O6ZFKLr8w2lN/zgAWB0awg (envelope-from ) for ; Wed, 25 Mar 2026 11:18:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=bhMtNoTH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 926781E0BC; Wed, 25 Mar 2026 11:18:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 969651E04F for ; Wed, 25 Mar 2026 11:18:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 238404BB3BFC for ; Wed, 25 Mar 2026 15:18:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 238404BB3BFC Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=bhMtNoTH Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7927E4BAD159 for ; Wed, 25 Mar 2026 15:17:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7927E4BAD159 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7927E4BAD159 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774451871; cv=none; b=kWtxuICHo4JtU5g3XlPhqTqgCtQiOPrBxljhNwTntomqxmguX9NefbesAx7iB92R/Tc782Tnd1y4K0CAXC+XC8ixx+0HWhDYW94tY7oejrQ7QqgXgH/D/0lQ2ssXIvnTIu187Q7hVOP4YkzA87oEmXZmtzAnXr5lD9A0kergWAc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774451871; c=relaxed/simple; bh=8qUgwh/xe0to0mL64jmoZDt50C58QfQM0s2yG54ycQo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Ai3lTZFcKPstSmlrnqrUSvz/O/zKknS6RaXCzkrcisjzJwi8Mq3fz4J0q4I/abEKr1Q8AkC0s13SAWi6b2+XzfHEmXyre/r9/PTep5GRGpkoJhC/pXypy23ueysVzOHEoA9sasUgA0tItpYmQr/HihNpB4wyrMIinkjcLdRFCIU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7927E4BAD159 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 62PFHfpl113872 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2026 11:17:46 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 62PFHfpl113872 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1774451867; bh=d9LWlZMM5PF+FGFId5HBb/+/dmOHuyi34lZfhETFkZY=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=bhMtNoTH5ZGdc4OMAn0zjCV8rY/aALkjtjzdycj4F/fcHhl4sTvzLM87tpaVMStKV MNty8pO5Jb9RgwkNopgvtiMtHWh3EgeJd1aGptWYqV+ha6pJvaD4VKu/GWMFqc8+Y4 JKQYQSfANAgi3psKo3s4z0oUeLeaQsPrfMfyVgt+dHutTq1mw2G6YuFBIHAIWZtLvl r1TPtLp9Frly2unGnZBYA5CcDjga4rf4JDCGawyhLuZlFRrsu/RDLdi+t8M+QSKSBo KZJnXaoBLs/nTZbtD3gE+8bb5LY5zxk2wVWoFh7RSIWcOEF6ta0owOi7J8/sAN1OWV OR/xtmhA4GyAA== Received: by simark.ca (Postfix) id E27041E04F; Wed, 25 Mar 2026 11:17:40 -0400 (EDT) Message-ID: <42610d74-54cb-4fda-a0b9-57e79e2ba733@polymtl.ca> Date: Wed, 25 Mar 2026 11:17:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Fix asertion failure while analysing core files in AIX with terminated threads. To: Ulrich Weigand , "akamath996@gmail.com" , "tom@tromey.com" Cc: "gdb-patches@sourceware.org" , SANGAMESH MALLAYYA , Aditya Kamath References: <20260324141545.32330-2-akamath996@gmail.com> <20468072-2ecc-43e7-bbf8-c946d7f8b79b@polymtl.ca> <9de3ac99112872c11db88d6c0e8f77364f1284c4.camel@de.ibm.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <9de3ac99112872c11db88d6c0e8f77364f1284c4.camel@de.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 25 Mar 2026 15:17:41 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-03-25 07:56, Ulrich Weigand wrote: > Simon Marchi wrote: >> On 3/24/26 10:15 AM, Aditya Vidyadhar Kamath wrote: >>> From: Aditya Vidyadhar Kamath >>> >>> If we analyse core files today in AIX ( few of them ) we get, >>> regcache.c:432: internal-error: get_thread_regcache: >>> Assertion `thread->state != THREAD_EXITED' failed. >> >>> The reason being the aix-thread.c file where root cause is the >>> sync_threadlists() >>> function. When reading an AIX core file, threads are reported by >>> libpthread library as being in PST_TERM (terminated) state, which >>> is correct since process crashed. However, sync_threadlists() was >>> calling delete_thread() for these terminated threads, marking them >>> as THREAD_EXITED in GDBs internal state. >> >> Looking at how it works on Linux, the threads are in state >> THREAD_STOPPED when looking at a core dump. I think that >> THREAD_STOPPED >> makes sense, because when looking at a core, you are looking at a >> snapshot of the process state when it was still alive, with all >> threads stopped. > > Isn't this actually what happens with Aditya's latest patch? > Given that sync_threadlists is no longer called, all threads > should remain in the state common code set up for them initially, > which I think would be THREAD_STOPPED? > > Bye, > Ulrich Ah ok, I didn't catch that, but now that I re-read the commit message it indeed sounds like it, thanks. Simon