Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Refactor ser-unix.c
Date: Fri, 25 Mar 2005 19:48:00 -0000	[thread overview]
Message-ID: <42446ADC.108@codesourcery.com> (raw)
In-Reply-To: <200503251849.j2PInBBr029982@elgar.sibelius.xs4all.nl>

Mark Kettenis wrote:

>    In order to keep the patch easiser to read, I did not rename the
>    ser-base.c routines with a ser_base prefix instead of the current
>    ser_unix prefix, but I would like to make that change before
>    check-in.
> 
> Yes, please; the ser_unix prefix doesn't really make sense for the
> functions in set-base.c.  I presume is also makes sense to drop the
> _nop_ in that operation.  You may check in this patch and than do the
> rename in a seperate patch, or do it both at once.  Consider the
> rename patch pre-approved.

I checked in the original patch, and will now work on the renaming patch.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


      reply	other threads:[~2005-03-25 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-22  8:20 Mark Mitchell
2005-03-25 18:50 ` Mark Kettenis
2005-03-25 19:48   ` Mark Mitchell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42446ADC.108@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox