From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26748 invoked by alias); 16 Mar 2005 17:08:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26675 invoked from network); 16 Mar 2005 17:08:04 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 16 Mar 2005 17:08:04 -0000 Received: (qmail 30664 invoked from network); 16 Mar 2005 17:08:03 -0000 Received: from localhost (HELO ?192.168.0.4?) (mitchell@127.0.0.1) by mail.codesourcery.com with SMTP; 16 Mar 2005 17:08:03 -0000 Message-ID: <423867EC.2030301@codesourcery.com> Date: Wed, 16 Mar 2005 17:08:00 -0000 From: Mark Mitchell Organization: CodeSourcery, LLC User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: PATCH: Allow for systems that do not define SIGQUIT/SIGPIPE References: <200503161633.j2GGX3Fl020753@sethra.codesourcery.com> <20050316164309.GA5418@nevyn.them.org> <4238641D.70403@codesourcery.com> <20050316165213.GA6764@nevyn.them.org> In-Reply-To: <20050316165213.GA6764@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------000509090405000407020403" X-SW-Source: 2005-03/txt/msg00222.txt.bz2 This is a multi-part message in MIME format. --------------000509090405000407020403 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 285 Daniel Jacobowitz wrote: >>Actually, GCC doesn't warn because handle_sigquit references itself. :-) >> >>I'll make that change; OK, assuming it builds? > > > Yes, is ok. Checked in; here was the final patch. -- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304 --------------000509090405000407020403 Content-Type: text/plain; name="gdb.signals" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gdb.signals" Content-length: 3691 2005-03-16 Mark Mitchell * event-top.c (handle_sigquit): Do not define for systems without SIGQUIT. (sigquit_token): Likewise. (async_init_signals): Allow for systems that do not define SIGQUIT. * ser-tcp.c (net_open): Allow for systems that do not have SIGPIPE. Index: event-top.c =================================================================== RCS file: /cvs/src/src/gdb/event-top.c,v retrieving revision 1.39 retrieving revision 1.40 diff -c -5 -p -r1.39 -r1.40 *** event-top.c 12 Feb 2005 00:39:19 -0000 1.39 --- event-top.c 16 Mar 2005 17:05:31 -0000 1.40 *************** static void async_do_nothing (gdb_client *** 53,63 **** --- 53,65 ---- static void async_disconnect (gdb_client_data arg); static void async_stop_sig (gdb_client_data arg); static void async_float_handler (gdb_client_data arg); /* Signal handlers. */ + #ifdef SIGQUIT static void handle_sigquit (int sig); + #endif static void handle_sighup (int sig); static void handle_sigfpe (int sig); #if defined(SIGWINCH) && defined(SIGWINCH_HANDLER) static void handle_sigwinch (int sig); #endif *************** struct prompts the_prompts; *** 131,141 **** --- 133,145 ---- invoke_async_signal_handler. */ void *sigint_token; #ifdef SIGHUP void *sighup_token; #endif + #ifdef SIGQUIT void *sigquit_token; + #endif void *sigfpe_token; #if defined(SIGWINCH) && defined(SIGWINCH_HANDLER) void *sigwinch_token; #endif #ifdef STOP_SIGNAL *************** async_init_signals (void) *** 893,902 **** --- 897,907 ---- to the inferior and breakpoints will be ignored. */ #ifdef SIGTRAP signal (SIGTRAP, SIG_DFL); #endif + #ifdef SIGQUIT /* If we initialize SIGQUIT to SIG_IGN, then the SIG_IGN will get passed to the inferior, which we don't want. It would be possible to do a "signal (SIGQUIT, SIG_DFL)" after we fork, but on BSD4.3 systems using vfork, that can affect the GDB process as well as the inferior (the signal handling tables *************** async_init_signals (void) *** 904,913 **** --- 909,919 ---- a handler for SIGQUIT, when we call exec it will set the signal to SIG_DFL for us. */ signal (SIGQUIT, handle_sigquit); sigquit_token = create_async_signal_handler (async_do_nothing, NULL); + #endif #ifdef SIGHUP if (signal (SIGHUP, handle_sighup) != SIG_IGN) sighup_token = create_async_signal_handler (async_disconnect, NULL); else *************** async_request_quit (gdb_client_data arg) *** 964,981 **** --- 970,989 ---- { quit_flag = 1; quit (); } + #ifdef SIGQUIT /* Tell the event loop what to do if SIGQUIT is received. See event-signal.c. */ static void handle_sigquit (int sig) { mark_async_signal_handler_wrapper (sigquit_token); signal (sig, handle_sigquit); } + #endif /* Called by the event loop in response to a SIGQUIT. */ static void async_do_nothing (gdb_client_data arg) { Index: ser-tcp.c =================================================================== RCS file: /cvs/src/src/gdb/ser-tcp.c,v retrieving revision 1.17 retrieving revision 1.18 diff -c -5 -p -r1.17 -r1.18 *** ser-tcp.c 11 Feb 2005 04:06:04 -0000 1.17 --- ser-tcp.c 16 Mar 2005 17:05:31 -0000 1.18 *************** net_open (struct serial *scb, const char *** 184,196 **** --- 184,198 ---- tmp = 1; setsockopt (scb->fd, IPPROTO_TCP, TCP_NODELAY, (char *)&tmp, sizeof (tmp)); } + #ifdef SIGPIPE /* If we don't do this, then GDB simply exits when the remote side dies. */ signal (SIGPIPE, SIG_IGN); + #endif return 0; } static void --------------000509090405000407020403--