From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52868 invoked by alias); 17 Sep 2018 16:59:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51011 invoked by uid 89); 17 Sep 2018 16:59:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=gnulib, HContent-Transfer-Encoding:8bit X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 16:59:01 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 1B4A510A87D; Mon, 17 Sep 2018 12:58:59 -0400 (EDT) Subject: Re: [PATCH v2 0/6] Add a new 'info proc files' command To: Simon Marchi , gdb-patches@sourceware.org References: <20180912233707.43492-1-jhb@FreeBSD.org> <2ef5236e-0b21-b669-6759-d4441a3e744c@simark.ca> From: John Baldwin Message-ID: <4228d440-13b6-73f6-751c-216bd2787ae2@FreeBSD.org> Date: Mon, 17 Sep 2018 16:59:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2ef5236e-0b21-b669-6759-d4441a3e744c@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00585.txt.bz2 On 9/15/18 7:34 PM, Simon Marchi wrote: > On 2018-09-12 7:37 p.m., John Baldwin wrote: >> This should include most of the suggested documentation fixes from the >> first series. It also adds an additional patch that attempts to tidy up >> some of the other "info proc" documentation. One change I haven't made >> (wasn't sure if it was still desired) was if we wanted to replace the >> specific annotations on individual 'info proc' subcommands about which >> OS's supported those commands with a single, more general statement that >> commands may only be supported on a subset of systems supported by GDB. >> >> I've moved more of the shared code for generating the 'info proc files' >> output to fbsd-tdep.c. >> >> One open question still from the first series is if GDB can assume the >> presence of routines like 'inet_ntoa' and 'inet_ntop' for formatting >> IPv4 and IPv6 addresses. It seems GDB does assume the presence of >> newer routines (e.g. getaddrinfo()) on POSIX systems in other places >> (e.g. ser-tcp.c), though in those places we use different APIs for >> Win32. > > There seems to be a gnulib module for that: > > https://www.gnu.org/software/gnulib/manual/html_node/inet_005fntop.html > > There is a page for inet_ntoa too: > > https://www.gnu.org/software/gnulib/manual/html_node/inet_005fntoa.html > > but there is no gnulib module for it. Probably because we can always > use inet_ntop instead? Yes, inet_ntop is sufficient for both. I had grepp'ed for 'ntoa' and 'ntop' in gdb/gnulib and didn't find any matches, so I assumed that meant there wasn't a module. Is gdb/gnulib a subset of the actual gnulib and new bits are imported on demand? Hmm, reading update-gnulib.sh, it seems so. I'll look at what is involved in doing that. -- John Baldwin                                                                            Â