From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 527 invoked by alias); 28 Feb 2005 19:39:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 450 invoked from network); 28 Feb 2005 19:39:08 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 28 Feb 2005 19:39:08 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1SJd7r4008743 for ; Mon, 28 Feb 2005 14:39:08 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1SJd7K20788; Mon, 28 Feb 2005 14:39:07 -0500 Received: from redhat.com (dhcp-172-16-25-137.sfbay.redhat.com [172.16.25.137]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j1SJd55s031993; Mon, 28 Feb 2005 14:39:05 -0500 Message-ID: <42237359.7020205@redhat.com> Date: Mon, 28 Feb 2005 23:02:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.3) Gecko/20040924 MIME-Version: 1.0 To: Daniel Jacobowitz CC: Nathan Sidwell , gdb-patches@sources.redhat.com, Paul Brook Subject: Re: [PATCH] More tracepoint fixes References: <4209DC23.4050102@codesourcery.com> <20050227002747.GB19138@nevyn.them.org> In-Reply-To: <20050227002747.GB19138@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-02/txt/msg00290.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Feb 09, 2005 at 09:47:15AM +0000, Nathan Sidwell wrote: > >>This is a more complicated tracepoint fix. The variable tracing mechanism >>does not cope with COMPUTED_LOC and ARG_COMPUTED_LOC symbols, as generated >>by gcc 3.4. Expressions containing said symbols are dealt with. This >>patch rearranges 'collect_symbol' and 'add_local_symbols' to deal with >>such computed symbols. These are dumped as if they were expressions -- >>hence the breakout of the expression dumping from encode_actions. >> >>built & tested on i686-pc-linux-gnu, and an unreleased remote >>architecture. ok? > > >>2005-02-09 Nathan Sidwell >> >> * tracepoint.c: #include gdb_assert.h >> (collect_symbol): Take a PC and EXP, not a symbol. Adjust. Add >> LOC_COMPUTED and LOC_COMPUTED_ARG cases. >> (add_local_symbols): Describe the symbol with an expression, >> adjust collect_symbol calls, add LOC_COMPUTED and LOC_COMPUTED_ARG >> cases. >> (encode_actions): Break out expression processing into ... >> (add_expression): ... here. New function. > > > It looks sane to me, but I really can't review this; Michael, could you > take a look at it? Yeah, I have it marked for attention. ;-/