From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27322 invoked by alias); 10 Feb 2005 08:33:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26459 invoked from network); 10 Feb 2005 08:33:06 -0000 Received: from unknown (HELO calvin.codito.co.in) (220.225.32.98) by sourceware.org with SMTP; 10 Feb 2005 08:33:06 -0000 Received: from [192.168.100.52] (ramana.codito.co.in [192.168.100.52]) by calvin.codito.co.in (8.12.10/8.12.10) with ESMTP id j1A8WmpU017917; Thu, 10 Feb 2005 14:02:49 +0530 Message-ID: <420B1C32.4060103@codito.com> Date: Thu, 10 Feb 2005 10:32:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla Thunderbird 0.8 (X11/20040926) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix for PR exp/1821 References: <41B35793.5010602@codito.com> <20041205191152.GA20357@nevyn.them.org> <32820.203.212.198.34.1102305828.squirrel@webmail.codito.com> <20050209230225.GA26434@nevyn.them.org> In-Reply-To: <20050209230225.GA26434@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------080609090400080700080307" X-SW-Source: 2005-02/txt/msg00083.txt.bz2 This is a multi-part message in MIME format. --------------080609090400080700080307 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 497 Hi Daniel, > Sorry about the slow review. There are still a number of problems. Thanks for the review. The attached patch solves the issues that you pointed out. Ok to commit ? > The patch itself still looks fine, so if you could just revise the > dependencies and testcase and repost, I'll try to be prompt. Do you > have write access? I don't have write access yet. So you would have to commit it . regards Ramana -- Ramana Radhakrishnan GNU Tools codito ergo sum (www.codito.com) --------------080609090400080700080307 Content-Type: text/plain; name="gdb1821revised" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gdb1821revised" Content-length: 4561 --- /dev/null 2005-02-10 14:35:17.859850120 +0530 +++ testsuite/gdb.base/gdb1821.exp 2005-02-10 09:21:37.213117432 +0530 @@ -0,0 +1,43 @@ +# Copyright 2005 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. + +# Tests for PR gdb/1821. +# 2004-12-06 Ramana Radhakrishnan + +# This file is part of the gdb testsuite. + +# +# test running programs +# + +set testfile "gdb1821" +set srcfile ${testfile}.c +set binfile ${objdir}/${subdir}/${testfile} + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { + return -1 +} + +gdb_exit +gdb_start +gdb_load ${binfile} + +if ![runto_main] then { + perror "couldn't run to breakpoint" + continue +} +gdb_test "print /x bar" "{x__0 = 0x0, y__0 = 0x0, z__1 = 0x0}" + --- /dev/null 2005-02-10 14:35:17.859850120 +0530 +++ testsuite/gdb.base/gdb1821.c 2005-02-10 09:22:30.116074960 +0530 @@ -0,0 +1,25 @@ +/* Test printing of structure member names in gdb. PR exp/1821 + + Copyright 2005, Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ + +struct foo { double x__0, y__0, z__1; } bar; + + +int main(void) { return 0; } Index: cp-valprint.c =================================================================== RCS file: /cvs/src/src/gdb/cp-valprint.c,v retrieving revision 1.36 diff -a -u -p -r1.36 cp-valprint.c --- cp-valprint.c 9 Feb 2005 00:04:28 -0000 1.36 +++ cp-valprint.c 10 Feb 2005 03:56:32 -0000 @@ -36,6 +36,7 @@ #include "cp-abi.h" #include "valprint.h" #include "cp-support.h" +#include "language.h" int vtblprint; /* Controls printing of vtbl's */ int objectprint; /* Controls looking up an object's derived type @@ -319,11 +320,11 @@ cp_print_value_fields (struct type *type if (TYPE_FIELD_STATIC (type, i)) fputs_filtered ("static ", stream); fprintf_symbol_filtered (stream, TYPE_FIELD_NAME (type, i), - language_cplus, + current_language->la_language, DMGL_PARAMS | DMGL_ANSI); fputs_filtered ("\" \"", stream); fprintf_symbol_filtered (stream, TYPE_FIELD_NAME (type, i), - language_cplus, + current_language->la_language, DMGL_PARAMS | DMGL_ANSI); fputs_filtered ("\") \"", stream); } Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.697 diff -a -u -p -r1.697 Makefile.in --- Makefile.in 9 Feb 2005 00:04:27 -0000 1.697 +++ Makefile.in 10 Feb 2005 03:57:34 -0000 @@ -1823,7 +1823,7 @@ cpu32bug-rom.o: cpu32bug-rom.c $(defs_h) cp-valprint.o: cp-valprint.c $(defs_h) $(gdb_obstack_h) $(symtab_h) \ $(gdbtypes_h) $(expression_h) $(value_h) $(command_h) $(gdbcmd_h) \ $(demangle_h) $(annotate_h) $(gdb_string_h) $(c_lang_h) $(target_h) \ - $(cp_abi_h) $(valprint_h) $(cp_support_h) + $(cp_abi_h) $(valprint_h) $(cp_support_h) $(language_h) cris-tdep.o: cris-tdep.c $(defs_h) $(frame_h) $(frame_unwind_h) \ $(frame_base_h) $(trad_frame_h) $(dwarf2_frame_h) $(symtab_h) \ $(inferior_h) $(gdbtypes_h) $(gdbcore_h) $(gdbcmd_h) $(target_h) \ --------------080609090400080700080307 Content-Type: text/plain; name="ChangeLoggdb1821" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ChangeLoggdb1821" Content-length: 379 2005-02-10 Ramana Radhakrishnan PR exp/1821 * cp-valprint.c(cp_print_value_fields): Include language.h . Pass current_language to fprintf_symbol_filtered * testsuite/gdb.base/gdb1821.c: New test file * testsuite/gdb.base/gdb1821.exp: New test file * Makefile.in: Update dependencies for cp-valprint.c --------------080609090400080700080307--