From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lZw7MRXpX2q3DyIAWB0awg (envelope-from ) for ; Tue, 21 Jul 2026 17:48:05 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ZxXhZna2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B5DA41E033; Tue, 21 Jul 2026 17:48:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3C9C51E033 for ; Tue, 21 Jul 2026 17:48:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 221C44BA2E0E for ; Tue, 21 Jul 2026 21:48:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 221C44BA2E0E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ZxXhZna2 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id C194A4BA543C for ; Tue, 21 Jul 2026 21:47:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C194A4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C194A4BA543C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784670462; cv=none; b=ruTE6P1cuztb2TAzaJ7TyPDO3oh0oyqstbm9XmdbleXSe832wUT6GHhvi+JtU4/Z7D4yB4X8BjkD50XG9TPx5zixhNUxAFSmlkCr3pT24v9Xz/UkPcgKbzWVIqvktx/48Gq0h/csyaRUD7mV0zMsHgsPBSw3+HYG21nBLtaJTSM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784670462; c=relaxed/simple; bh=/TLHiBHaMmHHFI4CBBwsdvei423SjeUyFvujvYSEvjo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ppcUGi2wn5b8dcGuXWiYf6NZgyYkcJ3E7sWrI7ax8DGPdxSoZY0YEB/1XXRRbbqCwU7wATuk5nSH6aiz6d3TmzDTSWHa5qaxo6/BNhDH4wNscdv4ZzjatFvd4wDbP8HTsNo9TIbg/3wgRSxoe46HC6taikaU5RchWBkZYwVQYsU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ZxXhZna2 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C194A4BA543C Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-493b966dd74so51713935e9.3 for ; Tue, 21 Jul 2026 14:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784670461; x=1785275261; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=d+n9S5F1kNzapz0ORtRHoIS77YKURhoLwUJWSMA53FI=; b=ZxXhZna2dyy+Ed4D9K20p5DzjuDVY/fcGghgGH0Xvfg0omieAe5HZjenV0W8Mvtc8w IyHvvfll+jgkN1Oh1vz3x2kNH+ErGFepWBcAujTjEj1dZpSdimNyEI/LzJS44ui7638Y 1nqnYsQe01zwq6pP6ik2P8Sczj31UhIgTeGuzxT18opgAxuAuKytCP8Pha46ncoFvtbY zPLhBqrkzZHxb1C/2qp8jzboYeZNvWUnm4/hLA/JjgrTg9B/LiiqR+l88EJMh64lhooI jLd+5rXAlZXkDVIR6Ac0p66MFSHHxguC2cqlyn9xgnMrvvaLwvKP7ByC7W/4Q4Yog671 4DrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784670461; x=1785275261; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d+n9S5F1kNzapz0ORtRHoIS77YKURhoLwUJWSMA53FI=; b=sCVR1KrXvgJPN6c5LfUeRCbcXWNoaLloIPxjdL13v1Wh/fY4QTWfUmBVOjqLMWQRjU pUuIVBtJoAa5JvNmykM5CyVrQfEMElGvuYCLZXCX09Q+irnamHGs+iGZA6LULlouZgQQ 9Y25RQWePM2PPBUru9uMXN1Kg49kldiBE/3MhGv0WmLx2E/ps2bpL2tvcH9Hi3EJmE2w WvgAVe8qiTbjFTP6YG18zhgeTItUOaq5hg0swKwPzwOuVTz/qd6/wtlr9HWjdWM7HOOE fCUTF1iX2H8Qxkq2AYP9W05tqQT3G/1Lq/+iOByHnGZtcgCT72vyR7IS4wlas0GEuaoE vdoQ== X-Forwarded-Encrypted: i=1; AHgh+Rp/lMfCj4bUG5Q9xmEDYBJQt0kFzyiADTJdX0GyQWrdYGA4N0VmYdqUQ+bT1eC2KxmLYP+J7WtMoCHRFA==@sourceware.org X-Gm-Message-State: AOJu0YwwoLO5f41J/YKqHG4XezpHymu/lEcIIjNgFTaonxXvH1Ga3Lvs +VUPxRUvyRO31LmZz5KYKr5c3YGGVfOFgtPXMsD48hYOZP6DZCjh+YuFul08+g== X-Gm-Gg: AR+sD12y2IZ4hEahC2YwK1Nn9M6WAqNwt5i+EIzM5Nv7rU8DLV+Nd10vu0vp5ND4L2X QFn5Vy+SouEmZ7ouX85YV+EYaCeC8AGjZ6Mvhh7b1Kmg6Y2MwyAXyErV1Lio/8BaGamUY0SkqEh ky+jnC+CYChpYHwObfa3RJxICGdXq32Or1cyyoaiGNUs2jrN5TAlF4vSCsEvF06EaIJUnL9tqfC vOpDznxI+ISh3sJah/xFOSyHCaEu4rIjh9DNo124pO1ac7Mlj9h9LqCdc5aIXCGwIIrzd/gLiT3 WlxUXsi/ImSgbAIpGSpduMTur4PQEb7DMW46ovtVA0oQMXPmoC49Hbk3TTV2l72RDj9KKQUhiC4 AmbLZfvAJ28ExE/j14rz2/Ap1N5OyFXLCeXCZQPCh1Kn1mmytzbVQ6oYN2IjnDltouRTteNES9u fbo4T1GdHAARQaWZY= X-Received: by 2002:a05:600c:1389:b0:495:5dcc:52ae with SMTP id 5b1f17b1804b1-4955dcc5372mr119946365e9.3.1784670460599; Tue, 21 Jul 2026 14:47:40 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a967289sm18765615e9.11.2026.07.21.14.47.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 14:47:39 -0700 (PDT) Message-ID: <42038b62-76dc-4d34-ae37-02bfd0331893@gmail.com> Date: Tue, 21 Jul 2026 22:47:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/10] gdb/linux-tdep: migrate linux_find_memory_regions_full to file_reader_t Content-Language: en-US To: Matthieu Longo , gdb-patches@sourceware.org Cc: Luis Machado , Andrew Burgess , Yury Khrustalev , Pedro Alves , Tom Tromey References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-8-matthieu.longo@arm.com> From: Luis In-Reply-To: <20260707154900.94542-8-matthieu.longo@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 07/07/2026 16:48, Matthieu Longo wrote: > The previous implementation of linux_find_memory_regions_full could > still return success even when none of the /proc/PID/[s]maps files > existed, or all reads returned 0 bytes (this last case can happen on > Linux when the thread-group leader has exited). > As a result, the function could incorrectly succeed, allowing core > dump generation via the gcore command. > This logical defect was allowing, by chance, the function to return > success and hence, allowing fortuitously the codedump generation via Typo: codedump -> coredump > gcore command (see gcore-stale-thread test for more details). > > A previous patch in this patch series fixed this issue by using the > first LWP ID of the current inferior instead of relying on the PID. > This patch adapts the code to use file_reader_t and makes the function > return an error is reading any of the procfs files fails. > --- > gdb/linux-tdep.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c > index a2af1586d35..f1cea3040f9 100644 > --- a/gdb/linux-tdep.c > +++ b/gdb/linux-tdep.c > @@ -1777,25 +1777,22 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch, > } > } > > - std::string maps_filename = string_printf ("/proc/%ld/smaps", ptid.lwp ()); > - > - gdb::unique_xmalloc_ptr data > - = target_fileio_read_stralloc (NULL, maps_filename.c_str ()); > + std::vector smaps; > > - if (data == NULL) > + file_reader_t smaps_freader > + (string_printf ("/proc/%ld/smaps", ptid.lwp ())); > + if (smaps_freader) > + smaps = parse_smaps_data (smaps_freader); > + else > { > /* Older Linux kernels did not support /proc/PID/smaps. */ > - maps_filename = string_printf ("/proc/%ld/maps", ptid.lwp ()); > - data = target_fileio_read_stralloc (NULL, maps_filename.c_str ()); > - > - if (data == nullptr) > + file_reader_t maps_freader > + (string_printf ("/proc/%ld/maps", ptid.lwp ())); > + if (!maps_freader) > return false; > + smaps = parse_smaps_data (maps_freader); > } > > - /* Parse the contents of smaps into a vector. */ > - std::vector smaps > - = parse_smaps_data (data.get (), maps_filename); > - > for (const struct smaps_data &map : smaps) > { > /* Invoke the callback function to create the corefile segment. */