From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30384 invoked by alias); 10 Sep 2017 09:03:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30370 invoked by uid 89); 10 Sep 2017 09:03:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=opportunity X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Sep 2017 09:03:03 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8A92uuW023445 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 10 Sep 2017 05:03:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 5CAA11EAAB; Sun, 10 Sep 2017 05:02:56 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id B73DB1EA17; Sun, 10 Sep 2017 05:02:35 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 10 Sep 2017 09:03:00 -0000 From: Simon Marchi To: Sergio Durigan Junior Cc: GDB Patches , Yao Qi Subject: Re: [PATCH] Fix build breakage on GNU/Linux AArch64 and use std::vector on tdesc.reg_defs In-Reply-To: <20170910055056.21186-1-sergiodj@redhat.com> References: <20170910055056.21186-1-sergiodj@redhat.com> Message-ID: <41ee3f9801392370c02481e2f77aa8dc@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 10 Sep 2017 09:02:56 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00266.txt.bz2 On 2017-09-10 07:50, Sergio Durigan Junior wrote: > This patch fixes the build breakage that has been happening on AArch64 > since September 5th. The breakage was introduced by the following > commit: > > author Yao Qi > Tue, 5 Sep 2017 04:54:52 -0400 (09:54 +0100) > committer Yao Qi > Tue, 5 Sep 2017 04:54:52 -0400 (09:54 +0100) > commit f7000548a2b79d7e5cb924468117ca4245e6b820 > > Use VEC for target_desc.reg_defs > > The build log for this commit can be seen here: > > > > > And the underlying problem is that the code is not calling the new > function "allocate_target_description" to allocate the "struct > target_desc" using "new" instead of XNEW, which end up not properly > initializing the fields of the structure. > > I took the opportunity to convert the code to std::vector (instead of > VEC), which makes things even simpler. This has been regtested on the > BuildBot, without regressions, and fixes the build breakage. Hi Sergio, This patch seems to do two independent changes: - use allocate_target_description instead of XNEW - replace VEC with std::vector Can you post separate patches? You can push the first one directly, I would call it obvious (and it's the important bits to fix the build). The second one, Yao might want to take a look. Thanks! Simon