From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MMpvOy61AWKFRAAAWB0awg (envelope-from ) for ; Mon, 07 Feb 2022 19:11:26 -0500 Received: by simark.ca (Postfix, from userid 112) id F17001F3C6; Mon, 7 Feb 2022 19:11:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7E6FD1EE1A for ; Mon, 7 Feb 2022 19:11:26 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CEF7C385841F for ; Tue, 8 Feb 2022 00:11:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CEF7C385841F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644279085; bh=fvNvMSYmgFSm1biapUpaSSbcPwzMeuWWoQYfDEqu8n0=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xp514X89prme8WPIz0Th4eXYuJPtdcsbDvp3SfLRXLL8MlX0FnnrtPQpDKFFpVhWq +JlS1MijnCosabzccPY0+b3NovjymjtcsB7nviKrVBsdlYszpue+yj9mX/5vscOzgL FfXjQoz/n7WM2++U9hrSmBk4rHfcqmcA7veHhCZU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 706733858C83 for ; Tue, 8 Feb 2022 00:11:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 706733858C83 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2180Atvn014002 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 7 Feb 2022 19:11:00 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2180Atvn014002 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9A48F1EE1A; Mon, 7 Feb 2022 19:10:55 -0500 (EST) Message-ID: <41ecbc94-012e-e765-e37f-3fd923276218@polymtl.ca> Date: Mon, 7 Feb 2022 19:10:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] gdb: remove tailing newlines from index_cache_debug calls Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <20220207204547.3364272-1-aburgess@redhat.com> In-Reply-To: <20220207204547.3364272-1-aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 8 Feb 2022 00:10:55 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-02-07 15:45, Andrew Burgess via Gdb-patches wrote: > I noticed that most of the calls to index_cache_debug include a > trailing newline. As the new debug mechanism already adds a newline, > that means all of these debug calls result in a blank line being > printed, which I think is a mistake. > > Remove all the trailing newlines. > > I also reformatted one of the index_cache_debug where a string will > now fit onto a single line. > > Unless 'set debug index-cache on' is used, there should be no visible > change in output after this commit. Thanks for doing this, it's surely an oversight on my part. I think it's an obvious change. Simon