From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cG+TOG2VcWnOGA8AWB0awg (envelope-from ) for ; Wed, 21 Jan 2026 22:11:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769051501; bh=dJ6TNpGS1dbodnyrU20/LVfQJPsbxIH2kCkRubDz+Xc=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vmU6ym/RkyAE3OCKN8jwG3OanybyhSms2MVQLbbnerdgHlQC/SAlQNj6DmM2nvZGr gNCU6zShg6Pnpa3ENOzBIhnbdREJ6406OWMhQbdChH/TKCvsDoLUKsKksPdWmMf/0l MABdMRTraxtfHnCMm8IPdrDIMWceeNGL+U07B80A= Received: by simark.ca (Postfix, from userid 112) id DA9F71E089; Wed, 21 Jan 2026 22:11:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=NfILGKjj; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BDE9D1E089 for ; Wed, 21 Jan 2026 22:11:40 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 959314BC897D for ; Thu, 22 Jan 2026 03:11:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 959314BC897D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=NfILGKjj Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7C86F4BA9003 for ; Thu, 22 Jan 2026 03:11:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C86F4BA9003 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C86F4BA9003 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769051471; cv=none; b=eGXn22AC+XIr/mdJQ7VluRxYm21R5U8bQkWmH+ldr69QAHBxvGohxU61wf8fuuPLYZi62ax0hxKIp+tJ6eoOZh807z8KpVn26QmIVaBMP2C7UwGfc5Eu6lJsRhBgX0I1247CN8vYDBgjdplRDOumy2dbM6WY/gmY9EaqmAK318I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769051471; c=relaxed/simple; bh=dJ6TNpGS1dbodnyrU20/LVfQJPsbxIH2kCkRubDz+Xc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KsEEi4vwIIbFKzZC0tRLZcnLwl866ZjzWAeU6mj73wOZZK2J2ngZFwQUBYdN95rHEQ1gofy3oN/EO2uy4gCrnApZkJlqtgMs7xr0gjWxBCQF6fGsd9TQaaPdGxCtiuMCvxu1CMU4iBPNDLccyDYaV2QeaByrpxP7eFvbe2v1foc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C86F4BA9003 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769051470; bh=dJ6TNpGS1dbodnyrU20/LVfQJPsbxIH2kCkRubDz+Xc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=NfILGKjjisIq8Ld6kHaC3pgq9RT9tVMW/g9uGiGaBt1vTDzoOVYphplAOqUr+Rpw3 BRYN/VVCRJr4DoTDjwKpuew09IqZ+fPc3e1WR1p1U/Y7bNlWyRm1+l3hixzn+c3L7s 8Ej62tbGwp1m7FogrVXCMSQc3BiewrTaiVB++ROg= Received: by simark.ca (Postfix) id 66EA61E089; Wed, 21 Jan 2026 22:11:10 -0500 (EST) Message-ID: <41e96643-513a-42f0-8618-ea5515380b9f@simark.ca> Date: Wed, 21 Jan 2026 22:11:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] Remove cp_lookup_transparent_type To: Tom Tromey , gdb-patches@sourceware.org References: <20260121-cp-remove-junk-v1-0-0999e81d866d@tromey.com> <20260121-cp-remove-junk-v1-1-0999e81d866d@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260121-cp-remove-junk-v1-1-0999e81d866d@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-21 19:51, Tom Tromey wrote: > cp_lookup_transparent_type seems to be a workaround for bugs in very > old compilers. A comment mentions that the bugs are fixed in GCC 3.4 > -- released in 2004. > > I think this is long past due for removal, which this patch does. I don't have first hand experience with this, but yeah this comment makes me confident that it is ok to remove: We should delete this functions once the appropriate debug information becomes more widespread. (GCC 3.4 will be the first released version of GCC with such information.) Approved-By: Simon Marchi Simon