On 19-06-19 14:43, Pedro Alves wrote:
> On 6/19/19 12:04 PM, Tom de Vries wrote:
>> Hi,
>>
>> When compiling with gcc 4.8, we run into:
>> ...
>> /usr/include/c++/4.8/bits/unordered_map.h:100:18: required from \
>>   ‘class std::unordered_map<sect_offset, std::vector<sect_offset> >’
>> src/gdb/dwarf2read.h:260:5:   required from here
>> /usr/include/c++/4.8/bits/hashtable_policy.h:1070:12: error: invalid use of \
>>   incomplete type ‘struct std::hash<sect_offset>’
>> ...
>>
>> Fix this by adding std::hash<sect_offset>.
>>
>> Build and reg-tested on x86_64-linux with gcc 4.8.
>>
>> OK for trunk?
>>
> 
> hash_enum was added for this:
> 
>  https://sourceware.org/ml/gdb-patches/2017-12/msg00210.html
> 
> Can you use it here?
> 
> It's currently used in dwarf2read.c, here:
> 
>   std::unordered_map<sect_offset,
> 		     dwarf2_per_cu_data *,
> 		     gdb::hash_enum<sect_offset>>
> 

Yes, that works for me.

OK for trunk?

Thanks,
- Tom