From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146509-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 113514 invoked by alias); 10 Apr 2018 21:52:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 113105 invoked by uid 89); 10 Apr 2018 21:52:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-11.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Apr 2018 21:52:38 +0000
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 5FBDB406E96B;	Tue, 10 Apr 2018 21:52:37 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id C78472023227;	Tue, 10 Apr 2018 21:52:36 +0000 (UTC)
Subject: Re: [PATCH v2 05/15] Fix elf_gnu_ifunc_resolve_by_got buglet
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
References: <20180325191943.8246-1-palves@redhat.com> <20180325191943.8246-6-palves@redhat.com> <65e568e8-ef50-0119-27ec-053849592706@simark.ca>
From: Pedro Alves <palves@redhat.com>
Message-ID: <41a9029b-326d-eac0-f7f2-67fcef97c3bb@redhat.com>
Date: Tue, 10 Apr 2018 21:52:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <65e568e8-ef50-0119-27ec-053849592706@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-04/txt/msg00201.txt.bz2

On 04/01/2018 05:32 AM, Simon Marchi wrote:
> On 2018-03-25 03:19 PM, Pedro Alves wrote:

>> --- a/gdb/elfread.c
>> +++ b/gdb/elfread.c
>> @@ -840,10 +840,12 @@ elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p)
>>  						 &current_target);
>>        addr = gdbarch_addr_bits_remove (gdbarch, addr);
>>  
>> -      if (addr_p)
>> -	*addr_p = addr;
>>        if (elf_gnu_ifunc_record_cache (name, addr))
>> -	return 1;
>> +	{
>> +	  if (addr_p)
> 
> addr_p != NULL ?
> 

Might as well.  I've done that locally.

Thanks,
Pedro Alves