From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15303 invoked by alias); 27 Jan 2005 23:06:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15281 invoked from network); 27 Jan 2005 23:06:32 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 27 Jan 2005 23:06:32 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j0RN6VFn027856 for ; Thu, 27 Jan 2005 18:06:31 -0500 Received: from localhost.redhat.com (vpn50-64.rdu.redhat.com [172.16.50.64]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j0RN6QO22720; Thu, 27 Jan 2005 18:06:26 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 42FAE7D79; Thu, 27 Jan 2005 18:06:20 -0500 (EST) Message-ID: <41F973EA.6030305@gnu.org> Date: Thu, 27 Jan 2005 23:06:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Tighten memory read/write methods References: <41F94AE7.4020405@gnu.org> <200501272103.j0RL3TWS001805@elgar.sibelius.xs4all.nl> In-Reply-To: <200501272103.j0RL3TWS001805@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-01/txt/msg00267.txt.bz2 Mark Kettenis wrote: > Date: Thu, 27 Jan 2005 15:11:19 -0500 > From: Andrew Cagney > > Hello, > > This cleans up the {target_,}{read,write}_memory methods making the > buffer parameter a bfd_byte (instead of "is it signed?" char) In constant propogating I'm making the following mind numbing transformations: char -> const bfd_byte unsigned char -> const bfd_byte void -> const void The first two are important. Some compilers [rightly] complain about incompatibility between signed/unsigned char; and on ppc with it's unsigned char, results just get weird. We can certainly debate the merits of ISO vs BFD and bfd_byte vs void, however lets keep that debate separate to my current task - getting constants sufficiently propogated for me to do my next value.h commit which in turn finishes DW_OP_piece. Andrew