From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2761 invoked by alias); 13 Dec 2004 20:45:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2714 invoked from network); 13 Dec 2004 20:45:07 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Dec 2004 20:45:07 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBDKj7XP017604 for ; Mon, 13 Dec 2004 15:45:07 -0500 Received: from localhost.redhat.com (vpn50-64.rdu.redhat.com [172.16.50.64]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBDKj6r21379; Mon, 13 Dec 2004 15:45:06 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 937A03EF9; Mon, 13 Dec 2004 15:42:59 -0500 (EST) Message-ID: <41BDFED3.10408@gnu.org> Date: Mon, 13 Dec 2004 21:34:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Randolph Chung Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] Add some flags to tramp frame unwinder References: <20041209172303.GF29171@tausq.org> <41BC730C.6050609@gnu.org> <20041213033707.GI29171@tausq.org> In-Reply-To: <20041213033707.GI29171@tausq.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-12/txt/msg00366.txt.bz2 Randolph Chung wrote: >>Instead of this, delete the test and in its place add a comment >>explaining what was there. I just hit another similar case - signal >>trampolines on altstacks - where there's either/or a valid symbol or >>segment. > > > ok, checked in the following > > > > 2004-12-12 Randolph Chung > > * tramp-frame.c (tramp_frame_sniffer): Allow frames with names or > sections to be trampolines too. Thanks. Andrew > Index: tramp-frame.c > =================================================================== > RCS file: /cvs/src/src/gdb/tramp-frame.c,v > retrieving revision 1.7 > diff -u -p -r1.7 tramp-frame.c > --- tramp-frame.c 7 Nov 2004 12:54:58 -0000 1.7 > +++ tramp-frame.c 13 Dec 2004 01:35:42 -0000 > @@ -122,19 +122,12 @@ tramp_frame_sniffer (const struct frame_ > const struct tramp_frame *tramp = self->unwind_data->tramp_frame; > CORE_ADDR pc = frame_pc_unwind (next_frame); > CORE_ADDR func; > - char *name; > struct tramp_frame_cache *tramp_cache; > > - /* If the function has a valid symbol name, it isn't a > - trampoline. */ > - find_pc_partial_function (pc, &name, NULL, NULL); > - if (name != NULL) > - return 0; > - /* If the function lives in a valid section (even without a starting > - point) it isn't a trampoline. */ > - if (find_pc_section (pc) != NULL) > - return 0; > - /* Finally, check that the trampoline matches at PC. */ > + /* tausq/2004-12-12: We used to assume if pc has a name or is in a valid > + section, then this is not a trampoline. However, this assumption is > + false on HPUX which has a signal trampoline that has a name; it can > + also be false when using an alternative signal stack. */ > func = tramp_frame_start (tramp, next_frame, pc); > if (func == 0) > return 0; > > randolph