From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18020 invoked by alias); 12 Dec 2004 18:33:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17987 invoked from network); 12 Dec 2004 18:33:46 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 12 Dec 2004 18:33:46 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBCIXkYY015754 for ; Sun, 12 Dec 2004 13:33:46 -0500 Received: from localhost.redhat.com (vpn50-50.rdu.redhat.com [172.16.50.50]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBCIXjr27760; Sun, 12 Dec 2004 13:33:45 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7C4513EF9; Sun, 12 Dec 2004 13:31:41 -0500 (EST) Message-ID: <41BC8E8B.5020200@gnu.org> Date: Sun, 12 Dec 2004 18:35:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Baurjan Ismagulov Cc: gdb-patches@sources.redhat.com Subject: Re: i18n, part 2 References: <20041204195702.GA25306@ata.cs.hun.edu.tr> In-Reply-To: <20041204195702.GA25306@ata.cs.hun.edu.tr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-12/txt/msg00343.txt.bz2 Baurjan Ismagulov wrote: > /* Add a command to allow the user to force the FPU model. */ > new_set = add_set_enum_cmd > ("fpu", no_class, fp_model_strings, ¤t_fp_model, > - "Set the floating point type.\n" > - "auto - Determine the FP typefrom the OS-ABI.\n" > - "softfpa - Software FP, mixed-endian doubles on little-endian ARMs.\n" > - "fpa - FPA co-processor (GCC compiled).\n" > - "softvfp - Software FP with pure-endian doubles.\n" > - "vfp - VFP co-processor.", > + _("Set the floating point type.\n\ > +auto - Determine the FP typefrom the OS-ABI.\n\ > +softfpa - Software FP, mixed-endian doubles on little-endian ARMs.\n\ > +fpa - FPA co-processor (GCC compiled).\n\ > +softvfp - Software FP with pure-endian doubles.\n\ > +vfp - VFP co-processor."), > &setarmcmdlist); > set_cmd_sfunc (new_set, set_fp_model_sfunc); > set_cmd_sfunc (deprecated_add_show_from_set (new_set, &showarmcmdlist), You might want to consider focusing on these set/show commands, and across all files. They need to be switched to the add_setshow_..._cmd form vis: > /* Debugging flag. */ > - add_setshow_boolean_cmd ("arm", class_maintenance, &arm_debug, "\ > -Set ARM debugging.", "\ > -Show ARM debugging.", "\ > -When on, arm-specific debugging is enabled.", "\ > -ARM debugging is %s.", > + add_setshow_boolean_cmd ("arm", class_maintenance, &arm_debug, > + _("Set ARM debugging."), > + _("Show ARM debugging."), > + _("When on, arm-specific debugging is enabled."), > + _("ARM debugging is %s."), > NULL, NULL, > &setdebuglist, &showdebuglist); > } as the former involves deprecated_add_show_from_set and what that does under the hood is very i18n-unfriendly. The current add_setshow_.._cmd implementation also has problems (it doesn't yet use the SHOW string) but at least all strings are present and correct. Andrew PS: Also recall my suggestion for adding something like _XXX or _FIXME as a way to mark that a string needs to be fixed on a second pass.