From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5537 invoked by alias); 12 Dec 2004 18:13:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5439 invoked from network); 12 Dec 2004 18:12:44 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 12 Dec 2004 18:12:44 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBCIChV5011855 for ; Sun, 12 Dec 2004 13:12:43 -0500 Received: from localhost.redhat.com (vpn50-50.rdu.redhat.com [172.16.50.50]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBCIChr25067; Sun, 12 Dec 2004 13:12:43 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E700C3EF9; Sun, 12 Dec 2004 13:10:39 -0500 (EST) Message-ID: <41BC899D.2050301@gnu.org> Date: Sun, 12 Dec 2004 18:17:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Generic support for qGetTLSAddr packet References: <20041206143109.7e29789f.kevinb@redhat.com> In-Reply-To: <20041206143109.7e29789f.kevinb@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-12/txt/msg00338.txt.bz2 Kevin Buettner wrote: > The patch below implements support for the qGetTLSAddr packet. See: > > http://sources.redhat.com/ml/gdb/2004-11/msg00189.html > > This patch also adds a new gdbarch method for fetching the OS / ABI > specific load module parameters. > > Still to come are three patches. They do the following: > > - Add documentation of remote_qGetTLSAddr_load_module_params to > gdbint.texinfo. > - Instantiate remote_qGetTLSAddr_load_module_params for GNU/Linux > running on an i386. > - Provide an implementation of the qGetTLSAddr packet for > gdbserver. Kevin, check my original comments about the protocol. I identified what you've hit here - having to add extra architecture methods. inferior.get_thread_local_address should take the raw address (to match the packet) and not the objfile parameter. The thread code can then extract the necessary address and call the target vector with it. Of course the linux nat code would also need to be adjusted. Consider the get_thread_local_address interface change pre-approved. Andrew PS: I'd stick with the qGetTLSAddr function name, it's consistent with the rest of remote.c where the corresponding packet name has been used, and makes tracking down the function much simpler.