From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14100 invoked by alias); 10 Dec 2004 19:04:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14080 invoked from network); 10 Dec 2004 19:04:41 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 10 Dec 2004 19:04:41 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBAJ4fBF027795 for ; Fri, 10 Dec 2004 14:04:41 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBAJ4fr09667; Fri, 10 Dec 2004 14:04:41 -0500 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id iBAJ4foS004854; Fri, 10 Dec 2004 14:04:41 -0500 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id D69758002A2; Fri, 10 Dec 2004 14:04:40 -0500 (EST) Message-ID: <41B9F348.3020300@redhat.com> Date: Fri, 10 Dec 2004 19:10:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Modified Watchthreads Patch References: <41B8E16D.6070505@redhat.com> <01c4deb2$Blat.v2.2.2$ce83b6e0@zahav.net.il> In-Reply-To: <01c4deb2$Blat.v2.2.2$ce83b6e0@zahav.net.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-12/txt/msg00271.txt.bz2 Eli Zaretskii wrote: >>Date: Thu, 09 Dec 2004 18:36:13 -0500 >>From: Jeff Johnston >> >>The following is a modified version of my thread watchpoint patch from >>October/November. It removes the code I had used to switch between lwp ptids >>and thread ptids now that Daniel's lwp patch is in place. It uses the former >>version of my observer that is linux-specific and is activated in attach_thread >>in linux-thread-db.c. Eli, I renamed the observer as asked to indicate this. > > > Thanks. > > >> * breakpoint.c (insert_watchpoints_for_new_thread): New function. >> (print_it_typical): Do not issue an error for bp_thread_event >> if a subsequent event is on the chain. >> * breakpoint.h (insert_watchpoints_for_new_thread): New prototype. > > > Hmm... the new function insert_watchpoints_for_new_thread is called > only by ia64_linux_new_thread. Is there any policy for functions that > are only used by a single port? Do we care that all the other GDB > builds will get a useless function compiled into them? Should we > perhaps #ifdef it away conditioned on some symbol? > > >>+@deftypefun void linux_new_thread (ptid_t @var{ptid}) >>+A new linux thread described by @var{ptid} has been officially attached >>+to by gdb. >>+@end deftypefun > > > What does it mean ``officially attached''? Can a thread be attached > to ``unofficially''? > I'm referring to the act of gdb recognizing the thread. The function itself is called attach_thread but it has a #ifdef governing whether a low-level ATTACH is required or not. Gdb now recognizes it has "attached" to the thread whether a physical attach is needed or not. I can drop the "officially" qualifier if it is confusing. -- Jeff J.