From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8742 invoked by alias); 2 Dec 2004 21:16:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8716 invoked from network); 2 Dec 2004 21:16:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 2 Dec 2004 21:16:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iB2LG1WU018957 for ; Thu, 2 Dec 2004 16:16:01 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iB2LG1r19597; Thu, 2 Dec 2004 16:16:01 -0500 Received: from redhat.com (dhcp-172-16-25-137.sfbay.redhat.com [172.16.25.137]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id iB2LFxso028753; Thu, 2 Dec 2004 16:15:59 -0500 Message-ID: <41AF860F.4060407@redhat.com> Date: Thu, 02 Dec 2004 21:16:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.3) Gecko/20040924 MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: [rfa] Include the LWP in thread-db's PTIDs References: <20041010213630.GA8218@nevyn.them.org> <20041114191740.GA13719@nevyn.them.org> In-Reply-To: <20041114191740.GA13719@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-12/txt/msg00050.txt.bz2 Daniel Jacobowitz wrote: > On Sun, Oct 10, 2004 at 05:36:30PM -0400, Daniel Jacobowitz wrote: > >>At one time, I believe that thread-db.c was planned to support the full >>range of features supported by the libthread_db interface, presumably as >>defined by Sun's implementation. That never panned out, and while non-1:1 >>support did work at one point, I don't think it has in a long while. If it >>was wanted, I wouldn't re-implement it the same way. So this patch begins >>the process of removing unneeded generality from thread-db. In particular, >>while thread-db will still compute the TID, the mapping of threads to LWPs >>will be considered fixed. >> >>My goal is to have a GNU/Linux target vector, whose entry points call into >>thread-db when necessary, instead of having a thread-db wrapper around all >>the GNU/Linux methods. One of the things this will fix is the need for two >>separate versions of the GNU/Linux native wait() code - we will always use >>the multi-threaded-aware version. Another thing it will fix is a bug in the >>fork-following code which tries to find the LWP from a thread ID. >> >>This patch tested on i686-pc-linux-gnu using NPTL; no regressions. OK? > > > Here's the patch, updated to apply to linux-thread-db.c instead. Still > no regressions; Mark indicated that the 1:1 assumption seemed reasonable > once the file was marked as Linux-specific. > > Michael, OK to commit? Hey, sorry for losing this thread. Yes, this is OK to commit.