Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>,
	Jerome Guitton <guitton@act-europe.fr>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFA/testsuite] Ada fixed points [was stabs: octal negative numbers]
Date: Mon, 29 Nov 2004 15:21:00 -0000	[thread overview]
Message-ID: <41AB3E1D.90306@gnu.org> (raw)
In-Reply-To: <20041129134231.GA29157@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Mon, Nov 29, 2004 at 11:24:24AM +0100, Jerome Guitton wrote:
> 
>>Daniel Jacobowitz (drow@false.org):
>>
>>
>>>Please don't hardcode "run".  Can you use
>>> "runto ${srcfile}:$bp_location"
>>>instead of these two lines?
>>
>>>Please add a copyright notice to this file.
>>
>>Daniel,
>>
>>Thank you for your review. I fixed these two problems; new files in
>>attachment. OK now?
> 
> 
> Yes, this testcase is OK.  Thanks!

Sigh.

Jerome, Daniel,

If this test is instead added to the gdb.stabs directory we'll get far 
better mileage - few, if anyone, has an Ada compiler, yet almost 
everyone has the ability to build/run the gdb.stabs testsuite.

Andrew



  reply	other threads:[~2004-11-29 15:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-26 17:39 [RFA] stabs: octal negative numbers Jerome Guitton
2004-10-26 17:50 ` Joel Brobecker
2004-11-23 14:10 ` Jerome Guitton
2004-11-23 14:32   ` Elena Zannoni
2004-11-23 14:38     ` Jerome Guitton
2004-11-25 19:20       ` [RFA/testsuite] Ada fixed points [was stabs: octal negative numbers] Jerome Guitton
2004-11-28 17:49         ` Daniel Jacobowitz
2004-11-29 10:24           ` Jerome Guitton
2004-11-29 13:42             ` Daniel Jacobowitz
2004-11-29 15:21               ` Andrew Cagney [this message]
2004-11-29 15:26                 ` Daniel Jacobowitz
2004-11-29 17:24                 ` Jerome Guitton
2004-12-01 17:17                   ` Jerome Guitton
2004-12-13 17:21                     ` Jerome Guitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41AB3E1D.90306@gnu.org \
    --to=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=guitton@act-europe.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox