Re: Ping: [patch] general updates and improvements to QNX NTO support

Mark Kettenis
2004-12-03T16:17:38Z

Date: Fri, 03 Dec 2004 11:12:14 -0500
From: Kris Warkentin <kewarken@qnx.com>

Weekly ping. It's really not that bad....I ran gdb_indent.sh on
it....it's only affecting QNX specific stuff....I tested it on Windows,
Linux and Neutrino...

It is bad. It defines variables in a header file. That's
unacceptable. What's your motivation for getting rid of `struct
nto_target_ops' in the first place? Seems like a step in the wrong
direction to me.

Please fix this, then resubmit. I promise to look at it in a timely
fashion if you do.

Mark