From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12299 invoked by alias); 13 Nov 2004 01:52:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12204 invoked from network); 13 Nov 2004 01:52:04 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Nov 2004 01:52:04 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iAD1pxNZ032110 for ; Fri, 12 Nov 2004 20:51:59 -0500 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iAD1pxr21163; Fri, 12 Nov 2004 20:51:59 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DE833129D8C; Fri, 12 Nov 2004 20:50:35 -0500 (EST) Message-ID: <41956868.9020904@gnu.org> Date: Sat, 13 Nov 2004 01:52:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Andrew Cagney Cc: Randolph Chung , gdb-patches@sources.redhat.com Subject: Re: [commit/value] Merge VALUE_REGNO and VALUE_FRAME_REGNUM References: <20041113010028.GM15714@tausq.org> <41956692.3010500@gnu.org> In-Reply-To: <41956692.3010500@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00281.txt.bz2 Andrew Cagney wrote: > Randolph Chung wrote: > >>> The're doing the same thing. This reduces them down to a single >>> macro, committed. >> >> >> >>> I'll be following up with a similar patch for lval_register and >>> lval_reg_frame_relative. >> >> >> >> >> umm... looks like the patch you committed also changed VALUE_TYPE, etc >> without modifying the targets. This breaks a lot of targets. Can you >> please fix them? :) > > > That's an earlier, and far larger patch. I'm checking each as I go with > both a native (PPC) and all the cross builds, but that still always > misses something. > > I'll go back through it, however, if something is causing you grief, I'd > just commit the obvious fix. Er, I take that back. I FOOBARED the crosses for VALUE_TYPE. I'll commit the fix short. sorry, Andrew