From: Andrew Cagney <cagney@gnu.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit/value] Merge VALUE_REGNO and VALUE_FRAME_REGNUM
Date: Sat, 13 Nov 2004 01:44:00 -0000 [thread overview]
Message-ID: <41956692.3010500@gnu.org> (raw)
In-Reply-To: <20041113010028.GM15714@tausq.org>
Randolph Chung wrote:
>>The're doing the same thing. This reduces them down to a single macro,
>>committed.
>
>
>>I'll be following up with a similar patch for lval_register and
>>lval_reg_frame_relative.
>
>
>
> umm... looks like the patch you committed also changed VALUE_TYPE, etc
> without modifying the targets. This breaks a lot of targets. Can you
> please fix them? :)
That's an earlier, and far larger patch. I'm checking each as I go with
both a native (PPC) and all the cross builds, but that still always
misses something.
I'll go back through it, however, if something is causing you grief, I'd
just commit the obvious fix.
Andrew
next prev parent reply other threads:[~2004-11-13 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-13 0:56 Andrew Cagney
2004-11-13 1:01 ` Randolph Chung
2004-11-13 1:44 ` Andrew Cagney [this message]
2004-11-13 1:52 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41956692.3010500@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox