From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6052 invoked by alias); 11 Nov 2004 16:38:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5994 invoked from network); 11 Nov 2004 16:38:10 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 11 Nov 2004 16:38:10 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iABGc9tF000591 for ; Thu, 11 Nov 2004 11:38:10 -0500 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iABGc9r29153; Thu, 11 Nov 2004 11:38:09 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 71345129D8C; Thu, 11 Nov 2004 11:36:59 -0500 (EST) Message-ID: <41939529.8050308@gnu.org> Date: Thu, 11 Nov 2004 16:38:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Convert COERCE_* to functions References: <41926591.9080206@gnu.org> <01c4c75e$Blat.v2.2.2$ca853fc0@zahav.net.il> In-Reply-To: <01c4c75e$Blat.v2.2.2$ca853fc0@zahav.net.il> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00227.txt.bz2 Eli Zaretskii wrote: >>Date: Wed, 10 Nov 2004 14:01:37 -0500 >>From: Andrew Cagney >> >>Tested on PPC FC3 with no regressions. > > > 1) Can you tell the reason for these changes? > > 2) Personally, I think that > > foo = foobar (foo); > > is not a good style of C programming. opaque `struct value' http://sources.redhat.com/ml/gdb/2004-11/msg00010.html Converting a macro to a function has for a long time been considered obvious. Andrew