From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28327 invoked by alias); 9 Nov 2004 16:12:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27778 invoked from network); 9 Nov 2004 16:11:48 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 9 Nov 2004 16:11:48 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA9GBc96021202 for ; Tue, 9 Nov 2004 11:11:43 -0500 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA9GBbr09352; Tue, 9 Nov 2004 11:11:37 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 61FAB129D8C; Tue, 9 Nov 2004 11:10:42 -0500 (EST) Message-ID: <4190EC00.6070501@gnu.org> Date: Tue, 09 Nov 2004 16:12:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: David Ung Cc: cgd@broadcom.com, gdb-patches@sources.redhat.com, nigel@mips.com Subject: Re: MIPS32 / MIPS64 release 2 support in simulator References: <1099495559.2778.53.camel@stockwell.mips.com> <1099576389.2778.90.camel@stockwell.mips.com> <418FA243.4060507@gnu.org> <1099937194.2780.151.camel@stockwell.mips.com> In-Reply-To: <1099937194.2780.151.camel@stockwell.mips.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00162.txt.bz2 David Ung wrote: > On Mon, 2004-11-08 at 16:43, Andrew Cagney wrote: > >>cgd@broadcom.com wrote: >> >>>At Thu, 4 Nov 2004 13:53:38 +0000 (UTC), "David Ung" wrote: >>> >>> >>>>I shall update mips.igen with the new r2 instructions and then submit it >>>>as a patch. >>> >>> >>>cool, thanks. >> >>Don't. These new changes go in a new file, and that file gets a very >>clear FSF copyright. >> >>Andrew David, this isn't a technical decision (if it were, Chris would be right). The new changes, or more exactly the new instructions, go in a new file clearly marked (C) FSF (and for that matter clearly stating that it was contributed by MIPS Inc). As for the mark-up of the existing instructions, that's mindnumming tedium. Sorry about this pedentary. I'm off to pester another lawyer. Andrew > arhh. Chris's argument of that the rest of the tools consider rev 2 > instructions as an ISA is quite a valid one. And for consistency with > the existing structure, it looks to be the right thing to do. > But when I got to merging in the r2 instructions into mips.igen, I do > see that for every mips32 / 64 instruction, I now have to also tag them > mips32r2 / 64r2. It would probably be nicer to just tell it to include > all the mips32 instructions (which would be like treating it as an > ASE). > But then again it brings us back to the original argument, and I > probably would lean slightly towards the ISA model and be part of > mips.igen depite polluting the whole file with *mips32r2: and *mips64r2: > tags. > > David. > >