From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-36785-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25388 invoked by alias); 9 Nov 2004 15:29:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25341 invoked from network); 9 Nov 2004 15:28:57 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 9 Nov 2004 15:28:57 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA9FSqMr006087
	for <gdb-patches@sources.redhat.com>; Tue, 9 Nov 2004 10:28:52 -0500
Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA9FSqr25615;
	Tue, 9 Nov 2004 10:28:52 -0500
Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP id 90720129D8C;
	Tue,  9 Nov 2004 10:27:57 -0500 (EST)
Message-ID: <4190E1F8.7000203@gnu.org>
Date: Tue, 09 Nov 2004 15:29:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla Thunderbird 0.8 (X11/20041020)
MIME-Version: 1.0
To: Eli Zaretskii <eliz@gnu.org>, Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Add add_setshow_enum_cmd, use in mips
References: <4183BD22.3090905@gnu.org> <01c4bed6$Blat.v2.2.2$fa231b20@zahav.net.il> <41856ECA.2060701@gnu.org> <01c4bfcd$Blat.v2.2.2$299ef260@zahav.net.il> <20041101051257.GA11134@nevyn.them.org> <01c4c057$Blat.v2.2.2$4cacd760@zahav.net.il> <20041101223716.GB28889@nevyn.them.org> <01c4c096$Blat.v2.2.2$d4f57520@zahav.net.il> <20041109011458.GA32113@nevyn.them.org> <01c4c618$Blat.v2.2.2$0b838560@zahav.net.il>
In-Reply-To: <01c4c618$Blat.v2.2.2$0b838560@zahav.net.il>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-11/txt/msg00159.txt.bz2

This whole thread is stupid.

Before committing a patch as I did, I ask the question:

``Could a review significantly alter the change?''

Conversely, when reviewing a change, I ask:

``Is the objection going to significantly alter the change?''

Here, I cloned a pre-existing interface, adding another variant.  Anyone 
on this list with the problem I hit would have come up with an identical 
change.

Waiting a week would have achieved what?

Andrew