From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zn5PIPw6q2W+UQEAWB0awg (envelope-from ) for ; Fri, 19 Jan 2024 22:16:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1705720572; bh=4e+G/y2NEtcLIB6AKFLkH9AVijG+2xFsoiEpLL3JHTo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VULF1y0KEOEcLU3inVNcx8EhixMXLciMNSAiu81hVCxOK1wllnpbbMdLWXOG83373 RvPpQhOGHKQ3XsMABJvw9kszD1NTUeZZuOUjYFJ3sycFqYXipZnhAr3PiZO0ZNz1T0 tY8U/0Hzwb8fdWIl+FM5b0D8fcAk4vAMLpB3wlj0= Received: by simark.ca (Postfix, from userid 112) id 772341E0D0; Fri, 19 Jan 2024 22:16:12 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Zl4LN4+N; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5CBF71E0C2 for ; Fri, 19 Jan 2024 22:16:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E414D385E45A for ; Sat, 20 Jan 2024 03:16:09 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1F77C385842B for ; Sat, 20 Jan 2024 03:15:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F77C385842B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F77C385842B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705720553; cv=none; b=g3tQnL/78fjR2FZ20QR6E/+lFANZjseEFJmOpDi1kU6Z4zH98hnU3D0BYQKhGh/nTDg2bWuQQfOMVtTPluf5FXGfIfOfIc8yJ03IFrFaq6nrZuIptKXQuUgH3Y5LTh0BYIrNVuZooKfqG2yUHDiw2oVtMaPY0ZWhymwNPymTlxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705720553; c=relaxed/simple; bh=4e+G/y2NEtcLIB6AKFLkH9AVijG+2xFsoiEpLL3JHTo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=v5z5ygK4HfZtc/irfpJuc90SuoHuzgaePNz7ri7w/rnQNOyJMC1lsipWz/OaXZPkUagxlQKCOvyCJ/TfZZCE+F/Gq2Q5PP7UUoUmcfXNq9CSnUYCnJ30j+kRoemBGebQUZdGTHqCC6I25e9J9jDdkB1mtHxtJXN49OIwmmLY9P0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1705720550; bh=4e+G/y2NEtcLIB6AKFLkH9AVijG+2xFsoiEpLL3JHTo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Zl4LN4+Nx2lJKZX7bHH0zIVAORSymrn10eXW0U1mHLe83dvHYDH3Gjn8j/c126AH4 XxEAxlCTK4xt7lH1UksnFeZzaF7Y5cR22r9zcw8YTxB/G4ibE0bS7JC3YHS1N3vH1c zO+igvKIkRku6WAbSguWPpAeWvmVLJ3GGaLovZrU= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 557881E098; Fri, 19 Jan 2024 22:15:50 -0500 (EST) Message-ID: <418e1e90-902e-4915-a664-4d3e1227c950@simark.ca> Date: Fri, 19 Jan 2024 22:15:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb: remove SYMBOL_*_OPS macros Content-Language: en-US To: Kevin Buettner , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240119203246.83805-1-simon.marchi@efficios.com> <20240119154528.4a023ea0@f39-zbm-amd> From: Simon Marchi In-Reply-To: <20240119154528.4a023ea0@f39-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-01-19 17:45, Kevin Buettner wrote: > On Fri, 19 Jan 2024 15:32:32 -0500 > Simon Marchi wrote: > >> New in v2: >> >> - remove one use of auto in findvar.c >> - fix formatting in frame.c >> >> Remove SYMBOL_BLOCK_OPS, SYMBOL_COMPUTED_OPS and SYMBOL_REGISTER_OPS, in >> favor of methods on struct symbol. More changes could be done here to >> improve the design and make things safer, but I just wanted to do a >> straightforward change to remove the macros for now. > > LGTM. > > Reviewed-by: Kevin Buettner > Thanks, pushed. Simon