From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21726 invoked by alias); 8 Nov 2004 16:47:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21551 invoked from network); 8 Nov 2004 16:47:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 8 Nov 2004 16:47:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA8GlTHp004131 for ; Mon, 8 Nov 2004 11:47:29 -0500 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA8GlRr30831; Mon, 8 Nov 2004 11:47:27 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5CBB9129D8C; Mon, 8 Nov 2004 11:46:39 -0500 (EST) Message-ID: <418FA2ED.3090804@gnu.org> Date: Mon, 08 Nov 2004 16:47:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com, drow@false.org Subject: Re: [COMMIT] Avoid unnecessary indirection when decoding DWARF CFI References: <200411052237.iA5MbWLG015153@elgar.sibelius.xs4all.nl> In-Reply-To: <200411052237.iA5MbWLG015153@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00132.txt.bz2 Mark Kettenis wrote: > This fixes the problems for me. It's better to skip the indirection > here anyway, since it will save a memory read and thus avoids any > problems with that. > > Committed, > > Mark > > P.S. Andrew, can you test it on your systems. I still like to get > this on the branch since it fixes a nasty problem on SPARC. But it > can wait until 6.3.1. Yes, it fixes the problem I was seeing. 6.3.1 is ok, but not 6.3. Andrew > Index: ChangeLog > from Mark Kettenis > > * dwarf2-frame.c (decode_frame_entry_1): Avoid indirection when > skipping a personality routine in a CIE augmentation. > > Index: dwarf2-frame.c > =================================================================== > RCS file: /cvs/src/src/gdb/dwarf2-frame.c,v > retrieving revision 1.42 > diff -u -p -r1.42 dwarf2-frame.c > --- dwarf2-frame.c 5 Nov 2004 15:16:44 -0000 1.42 > +++ dwarf2-frame.c 5 Nov 2004 22:30:07 -0000 > @@ -1380,8 +1380,8 @@ decode_frame_entry_1 (struct comp_unit * > /* "P" indicates a personality routine in the CIE augmentation. */ > else if (*augmentation == 'P') > { > - /* Skip. */ > - unsigned char encoding = *buf++; > + /* Skip. Avoid indirection since we throw away the result. */ > + unsigned char encoding = (*buf++) & ~DW_EH_PE_indirect; > read_encoded_value (unit, encoding, buf, &bytes_read); > buf += bytes_read; > augmentation++; >