From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23100 invoked by alias); 6 Nov 2004 00:48:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23085 invoked from network); 6 Nov 2004 00:48:07 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 6 Nov 2004 00:48:07 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA60m2Bs007928 for ; Fri, 5 Nov 2004 19:48:02 -0500 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA60lkr12910; Fri, 5 Nov 2004 19:47:47 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E4B1C129D8C; Fri, 5 Nov 2004 19:47:21 -0500 (EST) Message-ID: <418C1F18.3090805@gnu.org> Date: Sat, 06 Nov 2004 00:48:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [commit] Cleanup Incomplete CFI data; unspecified registers complaint Content-Type: multipart/mixed; boundary="------------000203080909000408060805" X-SW-Source: 2004-11/txt/msg00102.txt.bz2 This is a multi-part message in MIME format. --------------000203080909000408060805 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 320 Hello, This patch tweaks the dwarf2-frame.c complaint: - the register name is included - the complaint is supressed when init_reg() fixed things up if you were ever wondering why, even after implementing init_reg, the complaint didn't disappear, this is it. I think this is pretty straight forward, committed, Andrew --------------000203080909000408060805 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1233 2004-11-05 Andrew Cagney * dwarf2-frame.c (dwarf2_frame_cache): Only complain when both the CFI and the init_reg method leave the register unspecified. Include the register name in the "Incomplete CFI data" complaint. Supress leading zeros in the address. Index: dwarf2-frame.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2-frame.c,v retrieving revision 1.43 diff -p -u -r1.43 dwarf2-frame.c --- dwarf2-frame.c 5 Nov 2004 22:35:22 -0000 1.43 +++ dwarf2-frame.c 6 Nov 2004 00:37:53 -0000 @@ -674,9 +674,13 @@ dwarf2_frame_cache (struct frame_info *n table. We need a way of iterating through all the valid DWARF2 register numbers. */ if (fs->regs.reg[column].how == DWARF2_FRAME_REG_UNSPECIFIED) - complaint (&symfile_complaints, - "Incomplete CFI data; unspecified registers at 0x%s", - paddr (fs->pc)); + { + if (cache->reg[regnum].how == DWARF2_FRAME_REG_UNSPECIFIED) + complaint (&symfile_complaints, "\ +incomplete CFI data; unspecified registers (e.g., %s) at 0x%s", + gdbarch_register_name (gdbarch, regnum), + paddr_nz (fs->pc)); + } else cache->reg[regnum] = fs->regs.reg[column]; } --------------000203080909000408060805--