From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27110 invoked by alias); 5 Nov 2004 17:00:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27103 invoked from network); 5 Nov 2004 17:00:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 5 Nov 2004 17:00:36 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA5H0Vei011103 for ; Fri, 5 Nov 2004 12:00:36 -0500 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA5H0Tr04246; Fri, 5 Nov 2004 12:00:29 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1134B129D8C; Fri, 5 Nov 2004 12:00:13 -0500 (EST) Message-ID: <418BB19C.7000100@gnu.org> Date: Fri, 05 Nov 2004 17:00:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [COMMIT] Fix decoding CIE's in DWARF frame info References: <200411051543.iA5Fh1nK020633@juw15.nfra.nl> In-Reply-To: <200411051543.iA5Fh1nK020633@juw15.nfra.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00081.txt.bz2 Mark Kettenis wrote: > The old code didn't take into account that the encoding used to > specify the personality routine in the augmentation could be > DW_PE_EH_aligned. > > Fixed by the attach patch. > > Committed to mainline. I'll commit this to the branch later today. How are you testing this? I'm seeing: dwarf2-frame.c:1083: internal-error: Unsupported encoding: DW_EH_PE_indirect Andrew > Index: ChangeLog > =================================================================== > RCS file: /cvs/src/src/gdb/ChangeLog,v > retrieving revision 1.6577 > diff -u -p -r1.6577 ChangeLog > --- ChangeLog 5 Nov 2004 08:53:18 -0000 1.6577 > +++ ChangeLog 5 Nov 2004 15:12:42 -0000 > @@ -1,3 +1,8 @@ > +2004-11-05 Mark Kettenis > + > + * dwarf2-frame.c (decode_frame_entry_1): Correctly skip > + personality routine in a CIE augmentation. > + > 2004-11-05 Felix Lee > > * stack.c (set_current_sal_from_frame): New function. > Index: dwarf2-frame.c > =================================================================== > RCS file: /cvs/src/src/gdb/dwarf2-frame.c,v > retrieving revision 1.41 > diff -u -p -r1.41 dwarf2-frame.c > --- dwarf2-frame.c 4 Nov 2004 21:15:15 -0000 1.41 > +++ dwarf2-frame.c 5 Nov 2004 15:12:42 -0000 > @@ -1381,7 +1381,9 @@ decode_frame_entry_1 (struct comp_unit * > else if (*augmentation == 'P') > { > /* Skip. */ > - buf += size_of_encoded_value (*buf++); > + unsigned char encoding = *buf++; > + read_encoded_value (unit, encoding, buf, &bytes_read); > + buf += bytes_read; > augmentation++; > } >