From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12976 invoked by alias); 4 Nov 2004 18:28:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12951 invoked from network); 4 Nov 2004 18:28:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 4 Nov 2004 18:28:18 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA4ISIoe006077 for ; Thu, 4 Nov 2004 13:28:18 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA4ISDr29747; Thu, 4 Nov 2004 13:28:13 -0500 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id iA4ISCbU024444; Thu, 4 Nov 2004 13:28:12 -0500 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 3D6AF80002E; Thu, 4 Nov 2004 13:28:12 -0500 (EST) Message-ID: <418A74BC.4020302@redhat.com> Date: Thu, 04 Nov 2004 18:28:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Jeff Johnston Cc: Andrew Cagney , Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA]: issue warnings for frame offenses References: <417EBFF9.5060104@redhat.com> <20041026213037.GR1039@gnat.com> <41897333.6070201@gnu.org> <418A58F3.8000603@redhat.com> In-Reply-To: <418A58F3.8000603@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00065.txt.bz2 Jeff Johnston wrote: > > Sounds fine. I'll start working on it. I assume you meant > non_fatal_error below for the new function that issues the quit. > Ignore my question above. I understand what is asked for now. I was reading QUIT as being QUIT the current operation, but you mean it to be more severe so what you say below makes sense. -- Jeff J. >> - add a new fatal_error(): >> >> There should be a new error mechanism that throws a QUIT instead of >> ERROR. Code should not normally be catching QUIT (much unfortunately >> does). A fatal error is things like: syntax error; no target; lost >> target. Things like a memory access violation though are not fatal. >> >> - think about stopping code catching and then discarding QUIT >> Grep for RETURN_MASK_ALL in the sources - it should be >> RETURN_MASK_ERROR :-/ >> >> - modify the backtrace code to catch ERROR, but not QUIT >> >> Along the lines of Joel's suggestion, the backtrace command should >> catch ERROR (but should not catch QUIT). That way simple problems >> don't abort the script but fatal ones do. >> >>