From: Andrew Cagney <cagney@gnu.org>
To: "Joseph S. Myers" <joseph@codesourcery.com>,
Mark Kettenis <kettenis@gnu.org>
Cc: gdb-patches@gcc.gnu.org
Subject: Re: Patch to support AMD64 Solaris 10
Date: Mon, 01 Nov 2004 16:43:00 -0000 [thread overview]
Message-ID: <41866793.1070102@gnu.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0410251739090.3442@digraph.polyomino.org.uk>
Joseph, Mark,
GDB's acceptance criteria for patches such as this is pretty clear:
- (C) assignment
tick
- coding standard
just run it through ./gdb_indent.sh
- deprecation
oops
- ./gdb_ari.sh -Wari to flag other looming coding problems
This is often easiest after the event.
The only thing really blocking this patch is ``deprecation''. And
there, the same patch minus the TM file would be acceptable (such a GDB
would even build and to a point work) (notice how test results are not
one of the acceptance criteria ;-).
Joseph, can you submit an up-to-date patch _minus_ the TM file I'll
approve it? By getting that committed we can get the bulk of the patch
off the table. Then we can follow up with smaller patches addressing
each of the remaining problems. First with the missing multi-arch
macros, and second with any concerns with *-nat files.
Does that sound reasonable?
Andrew
next prev parent reply other threads:[~2004-11-01 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 17:48 Joseph S. Myers
2004-10-25 19:39 ` Andrew Cagney
2004-10-25 19:55 ` Mark Kettenis
2004-10-25 22:03 ` Joseph S. Myers
2004-10-26 19:44 ` Joseph S. Myers
2004-10-26 20:50 ` Mark Kettenis
2004-10-30 19:57 ` Mark Kettenis
2004-10-30 20:01 ` Joseph S. Myers
2004-11-01 16:43 ` Andrew Cagney [this message]
2004-11-01 20:08 ` Joseph S. Myers
2004-11-01 20:34 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41866793.1070102@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=kettenis@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox