From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10603 invoked by alias); 31 Oct 2004 23:01:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10579 invoked from network); 31 Oct 2004 23:01:57 -0000 Received: from unknown (HELO localhost.redhat.com) (24.42.65.225) by sourceware.org with SMTP; 31 Oct 2004 23:01:57 -0000 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4D367129D8C; Sun, 31 Oct 2004 18:01:31 -0500 (EST) Message-ID: <41856ECA.2060701@gnu.org> Date: Sun, 31 Oct 2004 23:01:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Add add_setshow_enum_cmd, use in mips References: <4183BD22.3090905@gnu.org> <01c4bed6$Blat.v2.2.2$fa231b20@zahav.net.il> In-Reply-To: <01c4bed6$Blat.v2.2.2$fa231b20@zahav.net.il> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00563.txt.bz2 Eli Zaretskii wrote: >>Date: Sat, 30 Oct 2004 12:11:14 -0400 >>From: Andrew Cagney >> >>Another cleanup. >> >>committed, > > > FWIW, I don't see why is this a ``cleanup'', nor why should it be > committed without going through an RFA. You are introducing a new > function, so at the very least the reasons for its introduction should > have been explained and other maintainers should have been given an > opportunity to suggest alternative designs. The missing add_setshow_enum_cmd both goes with, and is consistent, with the existing add_setshow zinteger, boolean, auto_boolean, filename, string, uinteger command functions I just plugged an obvious hole, and in the process fixed an i18n problem. Andrew