From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32298 invoked by alias); 31 Oct 2004 22:44:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32283 invoked from network); 31 Oct 2004 22:44:29 -0000 Received: from unknown (HELO localhost.redhat.com) (24.42.65.225) by sourceware.org with SMTP; 31 Oct 2004 22:44:29 -0000 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 257D1129D8C; Sun, 31 Oct 2004 17:44:01 -0500 (EST) Message-ID: <41856AAC.803@gnu.org> Date: Sun, 31 Oct 2004 22:44:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Fix info frame's saved registers output References: <41824D61.3050208@gnu.org> <01c4bed4$Blat.v2.2.2$7e1a1800@zahav.net.il> In-Reply-To: <01c4bed4$Blat.v2.2.2$7e1a1800@zahav.net.il> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00562.txt.bz2 Eli Zaretskii wrote: >>Date: Fri, 29 Oct 2004 10:02:09 -0400 >>From: Andrew Cagney >> >>2004-10-27 Andrew Cagney >> >> * trad-frame.c (trad_frame_get_prev_register): Use >> frame_unwind_register instead of frame_register_unwind > > > Isn't it confusing to have 2 different functions whose names are just > permutations of the same words? How can a GDB hacker know what is the > difference between frame_register_unwind and frame_unwind_register, > without reading the sources? True, wan't to rename it? At the top of frame.h there's a blurb proposed naming convention. Andrew