From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6396 invoked by alias); 27 Oct 2004 17:21:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6281 invoked from network); 27 Oct 2004 17:21:43 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 27 Oct 2004 17:21:43 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id i9RHLci9018575 for ; Wed, 27 Oct 2004 13:21:43 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9RHLZr11164; Wed, 27 Oct 2004 13:21:36 -0400 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5B5A1129D8B; Wed, 27 Oct 2004 13:20:13 -0400 (EDT) Message-ID: <417FD8C8.9040906@gnu.org> Date: Wed, 27 Oct 2004 17:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Kazuhiro Inaoka Cc: "gdb-patches@sources.redhat.com" Subject: Re: [PATCH] Fix build failure m32r-linux-run References: <4164E70F.4070504@renesas.com> In-Reply-To: <4164E70F.4070504@renesas.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00452.txt.bz2 (more backlogKazuhiro Inaoka wrote: > Hello, > > I noticed a build failure for m32r-linux-run. > This patch fixes the failure. Please commit it. > > sim/m32r/ChangeLog > > 2004-10-07 Kazuhiro Inaoka > > * traps-linux.c (m32r_trap): Remove dummy systemcall's entry of > __NR_ustat and __NR_get_kernel_syms. > Don't include linux/module.h. Ah, I see ustat is "deprecated", and get_kernel_syms isn't even documented. One note for next time, please use `cvs diff -u` or `cvs diff -c` when creating the diff, it's much easier to read/review. I've committed this to mainline and 6.3, thanks. Andrew > Regards, > > Kazuhiro Inaoka > > > > ------------------------------------------------------------------------ > > gcc -c -DHAVE_CONFIG_H -DWITH_DEFAULT_MODEL='"m32r/d"' -DPROFILE=1 -DWITH_PROFILE=-1 -DWITH_ALIGNMENT=STRICT_ALIGNMENT -DWITH_TARGET_BYTE_ORDER=BIG_ENDIAN -DWITH_ENVIRONMENT=ALL_ENVIRONMENT -DWITH_HOST_BYTE_ORDER=LITTLE_ENDIAN -DWITH_SCACHE=16384 -DM32R_LINUX -I. -I/home3/FSF/org_src/binutils/src.linux/sim/m32r -I../common -I/home3/FSF/org_src/binutils/src.linux/sim/m32r/../common -I../../include -I/home3/FSF/org_src/binutils/src.linux/sim/m32r/../../include -I../../bfd -I/home3/FSF/org_src/binutils/src.linux/sim/m32r/../../bfd -I../../opcodes -I/home3/FSF/org_src/binutils/src.linux/sim/m32r/../../opcodes -I../../intl -I/home3/FSF/org_src/binutils/src.linux/sim/m32r/../../intl -g -O2 /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c > In file included from /usr/include/linux/sched.h:11, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/timex.h:191: error: redefinition of `struct timex' > In file included from /usr/include/linux/sched.h:12, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/jiffies.h:16: error: parse error before "jiffies_64" > /usr/include/linux/jiffies.h:20: error: parse error before "get_jiffies_64" > In file included from /usr/include/linux/cpumask.h:8, > from /usr/include/linux/sched.h:15, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/bitmap.h: In function `bitmap_empty': > /usr/include/linux/bitmap.h:15: error: `BITS_PER_LONG' undeclared (first use in this function) > /usr/include/linux/bitmap.h:15: error: (Each undeclared identifier is reported only once > /usr/include/linux/bitmap.h:15: error: for each function it appears in.) > /usr/include/linux/bitmap.h: In function `bitmap_full': > /usr/include/linux/bitmap.h:29: error: `BITS_PER_LONG' undeclared (first use in this function) > /usr/include/linux/bitmap.h: In function `bitmap_equal': > /usr/include/linux/bitmap.h:44: error: `BITS_PER_LONG' undeclared (first use in this function) > /usr/include/linux/bitmap.h: In function `bitmap_shift_right': > /usr/include/linux/bitmap.h:85: error: `__shr_tmp' undeclared (first use in this function) > /usr/include/linux/bitmap.h: In function `bitmap_shift_left': > /usr/include/linux/bitmap.h:98: error: `__shl_tmp' undeclared (first use in this function) > /usr/include/linux/bitmap.h: In function `bitmap_weight': > /usr/include/linux/bitmap.h:144: error: `BITS_PER_LONG' undeclared (first use in this function) > In file included from /usr/include/linux/sched.h:15, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/cpumask.h: At top level: > /usr/include/linux/cpumask.h:15: error: variable-size type declared outside of any function > In file included from /usr/include/linux/sched.h:15, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/cpumask.h: In function `next_online_cpu': > /usr/include/linux/cpumask.h:56: error: structure has no member named `val' > In file included from /usr/include/linux/sched.h:21, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/asm/mmu.h: At top level: > /usr/include/asm/mmu.h:13: error: field `sem' has incomplete type > In file included from /usr/include/asm/smp.h:16, > from /usr/include/linux/smp.h:17, > from /usr/include/linux/sched.h:23, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/asm/fixmap.h:72: error: `FIX_ACPI_PAGES' undeclared here (not in a function) > /usr/include/asm/fixmap.h:72: error: enumerator value for `FIX_ACPI_END' not integer constant > /usr/include/asm/fixmap.h:84: error: parse error before "pgprot_t" > In file included from /usr/include/asm/smp.h:18, > from /usr/include/linux/smp.h:17, > from /usr/include/linux/sched.h:23, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/asm/mpspec.h:6:25: mach_mpspec.h: No such file or directory > In file included from /usr/include/asm/smp.h:18, > from /usr/include/linux/smp.h:17, > from /usr/include/linux/sched.h:23, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/asm/mpspec.h:8: error: `MAX_MP_BUSSES' undeclared here (not in a function) > /usr/include/asm/mpspec.h:9: error: `MAX_MP_BUSSES' undeclared here (not in a function) > /usr/include/asm/mpspec.h:10: error: `MAX_MP_BUSSES' undeclared here (not in a function) > /usr/include/asm/mpspec.h:12: error: `MAX_MP_BUSSES' undeclared here (not in a function) > /usr/include/asm/mpspec.h:19: error: `MAX_APICS' undeclared here (not in a function) > /usr/include/asm/mpspec.h:20: error: `MAX_MP_BUSSES' undeclared here (not in a function) > /usr/include/asm/mpspec.h:20: error: conflicting types for `mp_bus_id_to_type' > /usr/include/asm/mpspec.h:8: error: previous declaration of `mp_bus_id_to_type' > /usr/include/asm/mpspec.h:22: error: `MAX_IRQ_SOURCES' undeclared here (not in a function) > /usr/include/asm/mpspec.h:24: error: `MAX_MP_BUSSES' undeclared here (not in a function) > /usr/include/asm/mpspec.h:24: error: conflicting types for `mp_bus_id_to_pci_bus' > /usr/include/asm/mpspec.h:12: error: previous declaration of `mp_bus_id_to_pci_bus' > /usr/include/asm/mpspec.h:35: error: parse error before "id" > /usr/include/asm/mpspec.h:36: error: parse error before "address" > /usr/include/asm/mpspec.h:37: error: parse error before "id" > /usr/include/asm/mpspec.h:38: error: parse error before "bus_irq" > /usr/include/asm/mpspec.h:54: error: `MAX_APICS' undeclared here (not in a function) > /usr/include/asm/mpspec.h:54: error: variable-size type declared outside of any function > In file included from /usr/include/asm/smp.h:20, > from /usr/include/linux/smp.h:17, > from /usr/include/linux/sched.h:23, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/asm/io_apic.h:26: error: parse error before "u32" > /usr/include/asm/io_apic.h:28: error: parse error before "u32" > /usr/include/asm/io_apic.h:34: error: parse error before '}' token > /usr/include/asm/io_apic.h:37: error: parse error before "u32" > /usr/include/asm/io_apic.h:39: error: parse error before "u32" > /usr/include/asm/io_apic.h:45: error: parse error before '}' token > /usr/include/asm/io_apic.h:48: error: parse error before "u32" > /usr/include/asm/io_apic.h:50: error: parse error before "u32" > /usr/include/asm/io_apic.h:54: error: parse error before '}' token > /usr/include/asm/io_apic.h:57: error: parse error before "u32" > /usr/include/asm/io_apic.h:59: error: parse error before "u32" > /usr/include/asm/io_apic.h:62: error: parse error before '}' token > /usr/include/asm/io_apic.h:120: error: `MAX_IRQ_SOURCES' undeclared here (not in a function) > /usr/include/asm/io_apic.h:120: error: conflicting types for `mp_irqs' > /usr/include/asm/mpspec.h:22: error: previous declaration of `mp_irqs' > In file included from /usr/include/linux/smp.h:17, > from /usr/include/linux/sched.h:23, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/asm/smp.h:73:26: mach_apicdef.h: No such file or directory > In file included from /usr/include/linux/sched.h:23, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/smp.h: In function `on_each_cpu': > /usr/include/linux/smp.h:65: error: invalid type argument of `->' > /usr/include/linux/smp.h:68: error: invalid type argument of `->' > /usr/include/linux/smp.h:68: error: `TIF_NEED_RESCHED' undeclared (first use in this function) > In file included from /usr/include/linux/signal.h:6, > from /usr/include/linux/sched.h:25, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/asm/signal.h: At top level: > /usr/include/asm/signal.h:29: error: conflicting types for `sigset_t' > /usr/include/sys/select.h:38: error: previous declaration of `sigset_t' > In file included from /usr/include/linux/sched.h:29, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/completion.h:15: error: parse error before "wait_queue_head_t" > /usr/include/linux/completion.h: In function `init_completion': > /usr/include/linux/completion.h:26: error: dereferencing pointer to incomplete type > /usr/include/linux/completion.h:27: error: dereferencing pointer to incomplete type > In file included from /usr/include/linux/sched.h:30, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/pid.h: At top level: > /usr/include/linux/pid.h:18: error: field `task_list' has incomplete type > /usr/include/linux/pid.h:19: error: field `hash_chain' has incomplete type > /usr/include/linux/pid.h:24: error: field `pid_chain' has incomplete type > In file included from /usr/include/linux/sched.h:101, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/resource.h:21: error: redefinition of `struct rusage' > /usr/include/linux/resource.h:40: error: redefinition of `struct rlimit' > In file included from /usr/include/linux/sched.h:102, > from /usr/include/linux/module.h:10, > from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/timer.h:11: error: field `entry' has incomplete type > In file included from /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:42: > /usr/include/linux/module.h:190: error: field `list' has incomplete type > /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c: In function `t2h_addr': > /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:154: warning: return makes pointer from integer without a cast > /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c: In function `m32r_trap': > /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:514: error: storage size of `ubuf' isn't known > /home3/FSF/org_src/binutils/src.linux/sim/m32r/traps-linux.c:1122: error: storage size of `table' isn't known > make[2]: *** [traps-linux.o] Error 1 > > > ------------------------------------------------------------------------ > > Index: traps-linux.c > =================================================================== > RCS file: /cvs/src/src/sim/m32r/traps-linux.c,v > retrieving revision 1.1 > diff -r1.1 traps-linux.c > 42d41 > < #include > 512,532d510 > < case __NR_ustat: > < { > < struct ustat ubuf; > < > < result = ustat(arg1, &ubuf); > < errcode = errno; > < > < if (result != 0) > < break; > < > < ubuf.f_tfree = conv_endian(ubuf.f_tfree); > < ubuf.f_tinode = conv_endian(ubuf.f_tinode); > < if ((s.write_mem) (cb, &s, arg2, (char *) &ubuf, sizeof(ubuf)) > < != sizeof(ubuf)) > < { > < result = -1; > < errcode = EINVAL; > < } > < } > < break; > < > 1120,1139d1097 > < case __NR_get_kernel_syms: > < { > < struct kernel_sym table; > < > < result = get_kernel_syms(&table); > < errcode = errno; > < > < if (result != 0) > < break; > < > < table.value = conv_endian(table.value); > < if ((s.write_mem) (cb, &s, arg1, (char *) &table, sizeof(table)) > < != sizeof(table)) > < { > < result = -1; > < errcode = EINVAL; > < } > < } > < break; > <