From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24788 invoked by alias); 25 Oct 2004 23:03:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24780 invoked from network); 25 Oct 2004 23:03:28 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 25 Oct 2004 23:03:28 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id i9PN3Dt5018033 for ; Mon, 25 Oct 2004 19:03:23 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9PN3Cr08500; Mon, 25 Oct 2004 19:03:12 -0400 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 68D191294B5; Mon, 25 Oct 2004 19:02:02 -0400 (EDT) Message-ID: <417D85E8.7000805@gnu.org> Date: Mon, 25 Oct 2004 23:03:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Corinna Vinschen Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add parse_dwarf2_calling_convention functionality References: <20041007095401.GN6702@cygbert.vinschen.de> <20041008124826.GZ6702@cygbert.vinschen.de> <16760.31952.258767.923659@localhost.redhat.com> In-Reply-To: <16760.31952.258767.923659@localhost.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00421.txt.bz2 Elena Zannoni wrote: > Corinna Vinschen writes: > > Hi, > > > > Corinna > > > > * gdbarch.sh (parse_dwarf2_calling_convention): New method. > > * gdbarch.h, gdbarch.c: Re-generate. > > * arch-utils.c (default_parse_dwarf2_calling_convention): New function. > > * arch-utils.h (default_parse_dwarf2_calling_convention): New extern > > declaration. > > * dwarf2read.c (read_subroutine_type): Evaluate > > DW_AT_calling_convention attribute and call > > gdbarch_parse_dwarf2_calling_convention appropriately. > > > The dwarf2read.c part is approved if the rest gets approved. One mod, rather than adding this: > +# Evaluate DW_AT_calling_convention value and convert in a calling_convention > +# value in the functions main type. > +m::void:parse_dwarf2_calling_convention:int has_attr, unsigned long attr_val, unsigned char gcc_compiled, struct type *func_type:has_attr, attr_val, gcc_compiled, func_type:0:default_parse_dwarf2_calling_convention::0 to the architecture vector, take a look at: 13.2 Per-architecture module data http://sources.redhat.com/gdb/current/onlinedocs/gdbint_13.html#SEC114 it lets dwarf2 locally manage that method while still being per-architecture. Andrew