From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109981 invoked by alias); 23 Nov 2017 22:46:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109971 invoked by uid 89); 23 Nov 2017 22:46:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:366 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 22:46:07 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2B58A80C0A; Thu, 23 Nov 2017 22:46:06 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07624600C0; Thu, 23 Nov 2017 22:46:04 +0000 (UTC) Subject: Re: [PATCH] C++ify osdata To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20171118233827.7418-1-simon.marchi@polymtl.ca> <9d0b9473-1fd5-8310-0cde-8233efed58bc@redhat.com> <19f399ce-dfb9-15fd-41ed-2a4576a438f6@ericsson.com> From: Pedro Alves Message-ID: <4172ddfc-fb35-e7e6-f168-800eabb62b77@redhat.com> Date: Thu, 23 Nov 2017 22:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <19f399ce-dfb9-15fd-41ed-2a4576a438f6@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00582.txt.bz2 On 11/23/2017 06:39 PM, Simon Marchi wrote: > On 2017-11-23 07:54 AM, Pedro Alves wrote: >> Isn't this leaking the heap-allocated vectors? >> >> Why make it a map of pointers, actually? Why not: >> > Oops, thanks for noticing and for the suggestion. I don't know what I was thinking. > What about this patch? LGTM. Thanks, Pedro Alves