Re: Ping: Re: testcase for "absolute source" patch

[Michael Chastain <mec.gnu@mindspring.com>]

Hi Baurjan,

> All tests verify whether gdb finds (doesn't find) the files as expected.
> To achieve that, we place them in some specific locations, such as
> compilation directory, $PATH, gdb source path ("directory" command),
> etc. The files from previous tests could cause false failures for the
> tests where gdb is supposed not to find the file (all tests with '-'),
> or false passes for the tests where gdb could find the wrong file (e.g.,
> in the compilation directory rather than in the source path).
>
> ... I decided to delete all files after each test, thus
> making the tests independent of each other.
> 
> ... each test expects to find the directory hierarchy in some
> "standard" state (created til the line 206, just before the first
> test_bin) and has to leave it in the same state.

These would make good comments to add to the test script.  Indeed,
whenever the approval guy doesn't get something and the contributor
has to explain it, that explanation is a good candidate for a comment
in the source code.

Okay, I am looking at gdb.log and there is not enough trace information
about what directory is being tested.  Can you add something like this
to test_bin and test_src:

  proc test_bin () {
    ...
    if [catch {cd $gdb_wd} msg] {
      ...
    }
    pass "test_bin cd $gdb_wd"
    ...
  }

That is not really a test; it's more of a marker for people who are
reading gdb.log to figure out the tests.

Also the ChangeLong entry should have your name and the date on it.

Now for the substantive part ...

I'm getting four FAIL results with gdb HEAD:

  gdb.base/openp.exp: openp s1-da (non-existent source, basename, find in <dir>/$cdir/basename)
  gdb.base/openp.exp: openp s3-da (non-existent source, relative name, find in <dir>/$cdir/relative)
  gdb.base/openp.exp: openp s4-da (non-existent source, in the current dir, find in <dir>/$cdir/basename)
  gdb.base/openp.exp: openp s5-da (non-existent source, in the upper dir, find in <dir>/$cdir/relative)

Are these bugs in gdb or problems with the test script?

I looked at the first one, s1-da, and it looks like a problem with
the test script.  The test program is compiled with the bare basename
"openp.c".  But there is no copy of openp.c in $gdb_wd, and $cmd1
is a gdb "dir" command for another directory where there is no openp.c.
It looks like $gdb_resp for this test should not be "$src_txt",
but something more like "1\topenp.c: No such file or directory\\..*".
Or am I mis-reading something?

Michael

===

	* gdb.base/openp.c: New testcase.
	* gdb.base/openp.exp: New testcase checking for source, binary
	and compilation directory handling.