Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: Mark Kettenis <kettenis@gnu.org>, gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Build inf-ptrace.o when ptrace available
Date: Mon, 11 Oct 2004 17:24:00 -0000	[thread overview]
Message-ID: <416AC1AC.6050207@gnu.org> (raw)
In-Reply-To: <20041005225914.GA28588@nevyn.them.org>

> I still do not believe that configure testing should be used for this
> purpose.  If we end up moving the knowledge of natfiles into configure,
> then we can set inf-ptrace to be included for all native GNU/Linux
> targets easily enough.

So you're not objecting to changes making configure (actually 
configure.host and configure.tgt) directly handle what was previously in 
the .mh file ...

> Or there are other ways to do it, as below. 
> 
> One of the reasons why I hold this position is that it lets us give a
> more useful error message if someone's system is broken and can not
> compile inf-ptrace.c for some reason that the configure script
> detected.  They'll get either a link failure or a GDB which can't debug
> anything, instead of an error related to the compile problem.  My
> experience with automating distribution builds tells me that someone
> will come up with a way to break their system in this fashion.

..  but rather just objecting to having inf-ptrace selected dependant on 
autoconf magic?  I could equally hardwire it vis:

case $host in
   *-linux* | *-bsd* ) objs += inf-ptrace
esac

Can you show us the money here - on what systems did you encounter 
problems and what problems were they?

The most recent problem I can think of was with the TUI, and that was a 
straight configure.in bug.

>>>>>> >>>Why is it orthogonal?  If we assume that configure determines when /proc 
>>>>>> >>>and ptrace() and provides both to the user it certainly isn't.  Idea's 
>>>>>> >>>such as Mark's and mine would make it easier.
>>>
>>>> >
>>>> >
>>>> >Why is it related?  How would this make it easier?  It's not hard to
>>>> >add a new backend file to all the Linux targets; it's really not much
>>>> >different in a lot of little files than in one big one.  I've done this
>>>> >plenty of times.
>>
>>> 
>>> If we used configure.tgt and:
>>> 	switch "$target"
>>> 	 *-*-linux* ) "objs=objs symfile-mem.c"
>>> 	esac
>>> then all GNU/Linux systems will always and consistently include 
>>> symtab-mem.c.  We don't, they don't ...
> 
> 
> This is no harder than having a common linux.mh, as GCC has done for
> years (gcc/config/t-linux).  It's not a technical differece between
> configure-frobbing and makefile-fragmenting.

So initially we can migrate things to configure.host, and then, if 
things prove to unwieldly, look at refactoring it.  But not before.

Andrew



  parent reply	other threads:[~2004-10-11 17:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-01 20:40 Andrew Cagney
2004-10-01 21:54 ` Mark Kettenis
2004-10-04 14:24   ` Andrew Cagney
2004-10-04 14:34     ` Daniel Jacobowitz
2004-10-04 16:27       ` Andrew Cagney
2004-10-04 16:35         ` Daniel Jacobowitz
2004-10-05 22:44           ` Andrew Cagney
2004-10-05 22:59             ` Daniel Jacobowitz
2004-10-05 23:42               ` Andrew Cagney
2004-10-11 17:24               ` Andrew Cagney [this message]
2004-10-13 13:54                 ` Daniel Jacobowitz
2004-10-14 17:14                   ` Mark Kettenis
2004-10-04 17:20     ` Mark Kettenis
2004-10-04 17:51       ` Andrew Cagney
2004-10-04 18:23         ` Mark Kettenis
2004-10-03 14:50 ` Daniel Jacobowitz
2004-10-04 14:31   ` Andrew Cagney
2004-10-04 14:34     ` Daniel Jacobowitz
2004-10-04 16:18       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=416AC1AC.6050207@gnu.org \
    --to=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox