From: Andrew Cagney <cagney@gnu.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/mips] Proposal for inlining heuristic_proc_desc a bit...
Date: Mon, 11 Oct 2004 04:10:00 -0000 [thread overview]
Message-ID: <416A07B8.8090609@gnu.org> (raw)
In-Reply-To: <20041011030407.GC26446@gnat.com>
> Hello Andrew,
>
> what would you think of something like this. It's just a concept,
> it hasn't been compiled nor tested, but the idea is to remove the
> call to heuristic_proc_desc() in mips_insn32_frame_cache() by a
> a direct call to mips32_scan_prologue(). The same would be applied
> to mips16.
>
> The two things that are not obvious are:
>
> . Where should the SP be computed: in the caller ofo scan_prologue,
> or inside scan_prologue. I chose the latter.
Yes. One block of code with all the heuristics.
> . Should the scanning limit (200 bytes) be checked in the caller,
> or inside scan_prologue. Again, I chose the latter.
Yes (although I think that limit is bogus :-).
> This is mostly to avoid duplicating this code. What do you think?
Consider them pre approved.
> You know, heuristic_proc_desc() is in grave danger of dying :-).
> I have have a couple of things I'd like to work on first, but then
> it should be ripe for removal.
Andrew
prev parent reply other threads:[~2004-10-11 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 3:04 Joel Brobecker
2004-10-11 4:10 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416A07B8.8090609@gnu.org \
--to=cagney@gnu.org \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox