From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30591 invoked by alias); 5 Oct 2004 19:49:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30581 invoked from network); 5 Oct 2004 19:49:37 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 5 Oct 2004 19:49:37 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i95JnWtG029891 for ; Tue, 5 Oct 2004 15:49:37 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i95JnMr18045; Tue, 5 Oct 2004 15:49:22 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0E1CC28D2; Tue, 5 Oct 2004 15:49:08 -0400 (EDT) Message-ID: <4162FAB3.4010603@gnu.org> Date: Tue, 05 Oct 2004 19:49:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] Fix remote debugging References: <20041004200122.GA30774@nevyn.them.org> In-Reply-To: <20041004200122.GA30774@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00092.txt.bz2 > Your recent patch made it mandatory for any target which implements > to_xfer_partial to support TARGET_OBJECT_MEMORY, i.e. its > to_xfer_memory will be ignored. remote.c doesn't meet this new > requirement. I didn't check all the other targets with _partial > methods. > > OK? Tested on i386-pc-linux-gnu using gdbserver. Brings test results > from unspeakable back to merely disappointing. There's no gdbserver.exp unit test, wasn't one going to be added? (the patch is ok) Andrew