From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28670 invoked by alias); 4 Oct 2004 15:14:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28655 invoked from network); 4 Oct 2004 15:14:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 4 Oct 2004 15:14:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i94FEUj8030438 for ; Mon, 4 Oct 2004 11:14:31 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i94FEUr00586; Mon, 4 Oct 2004 11:14:30 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5D55B28D2; Mon, 4 Oct 2004 11:14:13 -0400 (EDT) Message-ID: <416168C5.6010601@gnu.org> Date: Mon, 04 Oct 2004 15:14:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: "Amit S. Kale" Cc: gdb-patches@sources.redhat.com Subject: Re: kgdb support for gdb References: <200410011314.33157.amitkale@linsyssoft.com> In-Reply-To: <200410011314.33157.amitkale@linsyssoft.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00050.txt.bz2 > Index: src/gdb/remote.c > =================================================================== > --- src.orig/gdb/remote.c 2004-09-25 01:21:18.000000000 +0530 > +++ src/gdb/remote.c 2004-10-01 12:58:49.000000000 +0530 > @@ -271,12 +271,13 @@ > > /* Default maximum number of characters in a packet body. Many > remote stubs have a hardwired buffer size of 400 bytes > - (c.f. BUFMAX in m68k-stub.c and i386-stub.c). BUFMAX-1 is used > + (c.f. BUFMAX in m68k-stub.c and i386-stub.c). > + BUFMAX is defined as 1024 in most kgdb stubs. BUFMAX-1 is used > as the maximum packet-size to ensure that the packet and an extra > NUL character can always fit in the buffer. This stops GDB > trashing stubs that try to squeeze an extra NUL into what is > already a full buffer (As of 1999-12-04 that was most stubs. */ > - rs->remote_packet_size = 400 - 1; > + rs->remote_packet_size = 1024 - 1; > > /* Should rs->sizeof_g_packet needs more space than the > default, adjust the size accordingly. Remember that each byte is > As the comment explains, the change is wrong. Can I suggest starting a new thread on gdb@ explaining the underlying problem that you're trying to fix here (however, can you also delay it a bit, gdb@'s currently dominated by MI questions). Andrew