From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1113 invoked by alias); 4 Oct 2004 14:24:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1093 invoked from network); 4 Oct 2004 14:24:58 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 4 Oct 2004 14:24:58 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i94EOlEs014235 for ; Mon, 4 Oct 2004 10:24:58 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i94EOlr10235; Mon, 4 Oct 2004 10:24:47 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BE6AE28D2; Mon, 4 Oct 2004 10:24:30 -0400 (EDT) Message-ID: <41615D1E.8070007@gnu.org> Date: Mon, 04 Oct 2004 14:24:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Build inf-ptrace.o when ptrace available References: <415DC09D.2070407@gnu.org> <200410012154.i91Ls6lE001359@elgar.sibelius.xs4all.nl> In-Reply-To: <200410012154.i91Ls6lE001359@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00044.txt.bz2 > Date: Fri, 01 Oct 2004 16:39:57 -0400 > From: Andrew Cagney > > Hello, > > This modifies GDB's configure to build inf-ptrace.o whenever the ptrace > call is available. Thoughts? > > I'm not sure. On the one hand, yes, inf-ptrace should compile & link > on any system that has ptrace. On the other hand, actually using this > stuff is still a per-target decision, and there are quite a few > targets that have ptrace, but dont use it (Solaris, OSF/1, HP-UX). FYI, it isn't _linked_, except on GDB executables that use it. > I'm also thinking about the ultimate replacement of the makefile > fragments in config/*/. I think we should move towards a configure > script where we can use wildcards to set some sensible defaults. > There we'd have something like: > > *-*-*bsd*) > native_sources="inf-ptrace.c bsd-nat.c" > ;; > > *-*-linux*) > native_sources="inf-ptrace.c linux-nat.c" > ;; Going forward we need to get GNU/Linux and other systems using procfs and an obvious migration path for that is to build support for both procfs and ptrace into a single GDB. The default being to use ptrace. > *-*-solaris*) > native_sources="inf-procfs.c" > ;; > > I'm not strongly opposed to your patch (but you should look at it > again, see the hunk below). I also think that the logic that adds > inf-ptrace.o / inf-ptrace.c doesn't belong in the "Checks for library > functions" section. I'd leave the AC_CHECK_FUNCS(ptrace) there > (possibly grouping it together with the check for ttrace), and put the > rest of the logic somewhere else. Ah. But where? I couldn't find anywhere. > Mark > > > @@ -532,6 +539,9 @@ if test -n "$[5]"; then > [Define to the type of arg 5 for ptrace.]) > fi > > +dnl If there is ptrace, add inf-ptrace to the compile list. > + > + Oops.