From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4939 invoked by alias); 28 Sep 2004 17:59:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4926 invoked from network); 28 Sep 2004 17:59:10 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 28 Sep 2004 17:59:10 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8SHx5F3031852 for ; Tue, 28 Sep 2004 13:59:10 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8SHx4r21256; Tue, 28 Sep 2004 13:59:04 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 8EFFF28D2; Tue, 28 Sep 2004 13:58:58 -0400 (EDT) Message-ID: <4159A662.2090407@gnu.org> Date: Tue, 28 Sep 2004 17:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Paul Hilfinger Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Turn on initial Ada support in GDB References: <20040927103327.450A8F2C33@nile.gnat.com> In-Reply-To: <20040927103327.450A8F2C33@nile.gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00454.txt.bz2 > With the following patch, I believe we have addressed all outstanding > requests for modifications. The most recent changes incorporated here > (to ada-lang.c and ada-lang.h) strip out the code that was #ifdefed > out depending on whether we were compiling from our internal sources > or the public tree, and also remove a few other definitions or > declarations that were unused as a result. The other files in the > patch are repostings of the previously approved portions (not yet applied > because the whole lot is interdependent). > > Paul Hilfinger > 2004-09-27 Paul N. Hilfinger > > Turn on initial Ada support (mainly expression evaluation). > > * Makefile.in (ada_lex_c): Define > (HFILES_NO_SRCDIR): Add ada-lang.h. Can these two lines be put on hold for a moment, there's a symtab change that should be run past the symtab reviewer. > (COMMON_OBS): Add ada-lang.o, ada-typeprint.o, ada-valprint.o. > (YYOBJ): Add ada-exp.o. otherwize all the Makefile stuff can go in. > (rule .l.c): Generalize to not mention ada. > (ada-lex.o): Remove (ada-lex.c is included by ada-exp.y). ... dig dig, ah, bleaugh :-) Leave this for the moment -> I'll tweak gdb_makefile.sh to better handle this. Just wonder if the above should be changed from .l.c to .l.h. (but which ever)? > (ada-lang.o): Add dependencies on completer.h, gdb_obstack.h, > hashtab.h. > (ada-tasks.o): Add dependency on gdb_string.h. > (ada-valprint.o): Add dependency on gdb_string.h. > (ada-exp.o): Add dependency on gdb_string.h. > > * symtab.c: Add dependency on ada-lang.h. > (symbol_natural_name): Add Ada case. > (symbol_demangled_name): Add Ada case. > (symbol_search_name): Add Ada case. This is for symtab review, can you post it separatly? > * symfile.c (init_filename_language_table): Add extensions for > Ada. Relativly obvious, yes, ok. > * defs.h (enum language): Add language_ada. M'kay. > > * gdbtypes.h (TYPE_FLAG_FIXED_INSTANCE): Define. It isn't used. > > * ada-lang.c: Strip code that is conditionalized out by GNAT_GDB. > (add_symbols_from_enclosing_procs): Make a no-op for now. > (ada_unqualified_name,add_angle_brackets,function_name_from_pc) > (extended_canonical_line_spec, find_sal_from_funcs_and_line) > (find_line_in_linetable, find_next_line_in_linetable) > (read_all_symtabs, is_plausible_func_for_line) > (adjust_pc_past_prologue, error_breakpoint_runtime_sym_not_found) > (is_runtime_sym_defined, check_size): Remove declaration. > (function_name_from_pc, ada_translate_error_message) > (ada_lookup_minimal_symbol): Remove definition. > (ada_add_block_symbols): Remove useless label. > * ada-lang.h (ada_maybe_exception_partial_symbol): Remove > useless declaration. > (ada_is_exception_sym): Likewise. Yes, and thanks. > doc ChangeLog: > > 2004-09-22 Paul N. Hilfinger > > * gdb.texinfo (Filenames): Add Ada suffixes. > (Ada) New section. For Eli, suggest posting it separatly. Andrew