From: Andrew Cagney <cagney@gnu.org>
To: Ian Lance Taylor <ian@wasabisystems.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH RFA: Handle lack of struct statfs in ppc/sim/emul_netbsd.c
Date: Fri, 24 Sep 2004 18:11:00 -0000 [thread overview]
Message-ID: <415462B9.1000906@gnu.org> (raw)
In-Reply-To: <20040921022638.24707.qmail@gossamer.airs.com>
> NetBSD post 2.0 has deprecated statfs in favor of statvfs. The statfs
> system call still exists for compatibility purposes (if COMPAT_20),
> but struct statfs has been removed from the header files.
>
> This breaks the PowerPC simulator, which assumes that the existence of
> the statfs function implies the existence of struct statfs.
>
> This patch fixes this problem in the obvious way.
>
> I'm not sure why the NetBSD emulation implements fstatfs(). With this
> patch, it will stop doing so. If implementing fstatfs() is important,
> somebody will have to add support for the new fstatvfs() system call.
GCC, or similar, in the very distant past must have needed it.
> OK for mainline?
I've checked it in (well will, once my build comes back).
thanks,
Andrew
> Ian
>
> * configure.in: Check for sys/mount.h, sys/vfs.h, sys/statfs.h.
> Check for struct statfs.
> * emul_netbsd.c: If not HAVE_STRUCT_STATFS, #undef HAVE_FSTATFS.
> * configure, config.in: Regenerate.
next prev parent reply other threads:[~2004-09-24 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 2:26 Ian Lance Taylor
2004-09-24 18:11 ` Andrew Cagney [this message]
2004-09-24 20:09 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415462B9.1000906@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ian@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox