From: Andrew Cagney <cagney@gnu.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Andrew Cagney <cagney@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [mips] Getting rid of heuristic proc_desc
Date: Fri, 24 Sep 2004 14:30:00 -0000 [thread overview]
Message-ID: <41542EE3.5020708@gnu.org> (raw)
In-Reply-To: <20040924001643.GK968@gnat.com>
> I was thinking that it should be possible to merge mips32_skip_prologue
> inside mips32_heuristic_proc_desc (what a bad name for this function
> now). But I am wondering if this wouldn't make heuristic_proc_desc too
> complicated?
Yes, I was thinking on similar lines:
- just delete mips32_skip_prologue
- have mips32_heuristic* return the CORE_ADDR of the end-of-prologue
instead of the proc-descr and use that
- and yes, rename heuristic* to something more meaningful (scan prologue?)
The other thing that affects this is skip_prologue_using_sal, perhaphs
MIPS should try using that.
> I am thinking also that if we were to inline after_prologue inside
> mips_skip_prologue, then maybe this would allow us to make some
> simplifications...
>
> And maybe all three ideas are orthogonal, and should all be applied?
>
> Hmm.... Not sure which way I should go. Any hunch?
Andrew
prev parent reply other threads:[~2004-09-24 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 0:16 Joel Brobecker
2004-09-24 14:30 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41542EE3.5020708@gnu.org \
--to=cagney@gnu.org \
--cc=brobecker@gnat.com \
--cc=cagney@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox