From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9621 invoked by alias); 23 Sep 2004 17:25:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9612 invoked from network); 23 Sep 2004 17:25:12 -0000 Received: from unknown (HELO smtp10.atl.mindspring.net) (207.69.200.246) by sourceware.org with SMTP; 23 Sep 2004 17:25:12 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by smtp10.atl.mindspring.net with esmtp (Exim 3.33 #1) id 1CAXLC-0006O9-00; Thu, 23 Sep 2004 13:25:10 -0400 Received: from mindspring.com (unknown [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 07D5E4B363; Thu, 23 Sep 2004 12:58:34 -0400 (EDT) Date: Thu, 23 Sep 2004 17:25:00 -0000 From: Michael Chastain To: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fixes testsuit/gdb.base/annota1.exp Cc: cagney@gnu.org Message-ID: <415300BA.nail1Q01VH9OJ@mindspring.com> References: <200409211441.33901.pgilliam@us.ibm.com> <200409220953.53052.pgilliam@us.ibm.com> <4151D7B4.1080306@gnu.org> <200409221910.41605.pgilliam@us.ibm.com> In-Reply-To: <200409221910.41605.pgilliam@us.ibm.com> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00375.txt.bz2 This is good work. Here's my nit-picking. The main issue is generating backtrace.c versus a static file. Michael . ChangeLog entry . Drop the "Please email any bugs, comments, ..." inside the file. . It's elegant to generate the C program, but there are a couple of problems. You're writing on the source tree which screws up people who run multiple test runs out of the same source tree simultaneously. And all the external calls need error checking. And there is a copyright notice in backtrace.c, but no license. Just drop the generation and supply backtrace.c like a normal file. That loses the ability to change subr_depth easily, but that's okay. . subr_depth is still cool, you just have to document that it has to match backtrace.c.