From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32422 invoked by alias); 21 Sep 2004 15:28:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32384 invoked from network); 21 Sep 2004 15:28:13 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 21 Sep 2004 15:28:13 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8LFS8wu026673 for ; Tue, 21 Sep 2004 11:28:08 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8LFRwr30799; Tue, 21 Sep 2004 11:27:58 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id CCAD828D2; Tue, 21 Sep 2004 11:25:41 -0400 (EDT) Message-ID: <415047F5.8030409@gnu.org> Date: Tue, 21 Sep 2004 15:28:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Paul Hilfinger Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Changes for architecture type vector in Ada References: <20040918223738.E613FF2B95@nile.gnat.com> In-Reply-To: <20040918223738.E613FF2B95@nile.gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00342.txt.bz2 > The following patch is intended to bring the Ada sources in line with the > C sources in their handling of language-specific types. (When I checked > this is, I also revised my last ChangeLog entry to give the right, i.e., > official, e-mail address). Thanks! Any complaints / suggestions on the interface (I'm not that happy with it). We[gdb community] only have all the others. > Andrew, at some point I asked you a question relevant to this patch > for which I seem to have mislaid any answer you may have given: If at > some point in a language-specific file, one needs to refer to a > language-specific type, what is the MC (methodologically correct) > method for accessing that type? By name, as by > language_lookup_primitive_type_by_name (seems a bit wasteful to have > to do a search), or by some other means? Thanks. I remember you asking the question, but when I went back I couldn't re-find it :-( Language lookup_primative_type_by_name struck be as just wrong. I even tried to eliminate it but stumbled into a minefield (something to do with how C & C++ are a hybrid, the details elude me). My hunch is that Ada, and the other languages, should instead have per-osabi local data (see reggroups for how to do this without needing changes to the architecture vector) that contains the language specific primitive types that they really need. -- With this in place, and having looked through the code, I think we've just: -- strip out the #ifdef GNAT_GDB code (I'll send you a better way to maintain local changes off-list) -- enable Ada left. Andrew