From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30508 invoked by alias); 13 Sep 2004 14:30:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30497 invoked from network); 13 Sep 2004 14:30:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Sep 2004 14:30:18 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8DEUIiv032658 for ; Mon, 13 Sep 2004 10:30:18 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8DEUBr21433; Mon, 13 Sep 2004 10:30:11 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5926128D2; Mon, 13 Sep 2004 10:27:59 -0400 (EDT) Message-ID: <4145AE6F.6070005@gnu.org> Date: Mon, 13 Sep 2004 14:30:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Eli Zaretskii Cc: drow@false.org, gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Eliminate TARGET_HAS_HARDWARE_WATCHPOINTS References: <413C6E8E.6030607@gnu.org> <01c49441$Blat.v2.2.2$ead61420@zahav.net.il> <413E25F6.7020908@gnu.org> <01c49557$Blat.v2.2.2$23f700a0@zahav.net.il> <413F170A.2070005@gnu.org> <01c495b7$Blat.v2.2.2$1f83c660@zahav.net.il> <20040908152315.GA28927@nevyn.them.org> <01c4961e$Blat.v2.2.2$d00fd3e0@zahav.net.il> <20040909035336.GA30215@nevyn.them.org> <01c49621$Blat.v2.2.2$eb2d05a0@zahav.net.il> <20040909124755.GA8559@nevyn.them.org> <01c4969e$Blat.v2.2.2$0e5a13c0@zahav.net.il> <414479DB.4090207@gnu.org> <01c498f8$Blat.v2.2.2$2c6144e0@zahav.net.il> In-Reply-To: <01c498f8$Blat.v2.2.2$2c6144e0@zahav.net.il> Content-Type: multipart/mixed; boundary="------------000908070209060702050401" X-SW-Source: 2004-09/txt/msg00206.txt.bz2 This is a multi-part message in MIME format. --------------000908070209060702050401 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1614 >>> Date: Sun, 12 Sep 2004 12:31:23 -0400 >>> From: Andrew Cagney >>> Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com >>> >> >>>> > I'm not sure the mere presence of DR_* automatically means that >>>> > hardware watchpoints are supported at run time. I'd prefer to hear >>>> > that from Mark or someone else who could tell for sure. >>>> > >>>> > In any case, if the above is true, then there should be no problem to >>>> > write an Autoconf test that would replace >>>> > TARGET_HAS_HARDWARE_WATCHPOINTS. As soon as that is posted here, I >>>> > will withdraw all my objections to removing the old macro in favor of >>>> > the new mechanism. >> >>> >>> This assumes that we've access to machines to test it on, and the code >>> being modified is even being used / worth retaining. Resolving both of >>> those takes this from a no-problem task to something best handled >>> separatly, and something that should not block this current patch. I've committed this part of my change: > - core GDB no longer refers to TARGET_HAS_HARDWARE_WATCHPOINTS > At one stage target.h had definitions dependant on this macro, but no more. This patch removes the no-longer-needed defintion from configurations, such as GNU/Linux. w.r.t., > Sorry, the person who wants to submit a patch for inclusion should do > the necessary reasearch required to verify that the patch is doing > TRT. That was done. To have anyone do more is a waste of effort. Anyway, this is all have been beaten to death in this thread, we are just reiterating the same issues again and again. Andrew --------------000908070209060702050401 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 4487 2004-09-13 Andrew Cagney * config/i386/nm-i386.h (TARGET_HAS_HARDWARE_WATCHPOINTS): Delete. * config/s390/nm-linux.h (TARGET_HAS_HARDWARE_WATCHPOINTS): Delete. * config/pa/nm-hppah.h (TARGET_HAS_HARDWARE_WATCHPOINTS): Delete. * config/ia64/nm-linux.h (TARGET_HAS_HARDWARE_WATCHPOINTS): Delete. * config/frv/tm-frv.h (TARGET_HAS_HARDWARE_WATCHPOINTS): Delete. * mips-tdep.c (mips_dump_tdep): Do not print same. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.322 diff -p -u -r1.322 mips-tdep.c --- mips-tdep.c 5 Sep 2004 20:15:40 -0000 1.322 +++ mips-tdep.c 13 Sep 2004 14:04:29 -0000 @@ -6604,9 +6604,6 @@ mips_dump_tdep (struct gdbarch *current_ "mips_dump_tdep: TARGET_CAN_USE_HARDWARE_WATCHPOINT # %s\n", XSTRING (TARGET_CAN_USE_HARDWARE_WATCHPOINT (TYPE, CNT, OTHERTYPE))); - fprintf_unfiltered (file, - "mips_dump_tdep: TARGET_HAS_HARDWARE_WATCHPOINTS # %s\n", - XSTRING (TARGET_HAS_HARDWARE_WATCHPOINTS)); #ifdef TRACE_CLEAR fprintf_unfiltered (file, "mips_dump_tdep: TRACE_CLEAR # %s\n", Index: config/frv/tm-frv.h =================================================================== RCS file: /cvs/src/src/gdb/config/frv/tm-frv.h,v retrieving revision 1.5 diff -p -u -r1.5 tm-frv.h --- config/frv/tm-frv.h 1 Aug 2004 14:37:01 -0000 1.5 +++ config/frv/tm-frv.h 13 Sep 2004 14:04:29 -0000 @@ -20,8 +20,6 @@ /* This target uses an architecture vector for most architecture methods. */ -#define TARGET_HAS_HARDWARE_WATCHPOINTS - #define TARGET_CAN_USE_HARDWARE_WATCHPOINT(type, cnt, ot) \ frv_check_watch_resources (type, cnt, ot) extern int frv_check_watch_resources (int type, int cnt, int ot); Index: config/i386/nm-i386.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/nm-i386.h,v retrieving revision 1.5 diff -p -u -r1.5 nm-i386.h --- config/i386/nm-i386.h 17 Jan 2004 21:56:12 -0000 1.5 +++ config/i386/nm-i386.h 13 Sep 2004 14:04:29 -0000 @@ -26,10 +26,6 @@ /* Targets should define this to use the generic x86 watchpoint support. */ #ifdef I386_USE_GENERIC_WATCHPOINTS -#ifndef TARGET_HAS_HARDWARE_WATCHPOINTS -#define TARGET_HAS_HARDWARE_WATCHPOINTS -#endif - /* Clear the reference counts and forget everything we knew about DRi. */ extern void i386_cleanup_dregs (void); Index: config/ia64/nm-linux.h =================================================================== RCS file: /cvs/src/src/gdb/config/ia64/nm-linux.h,v retrieving revision 1.14 diff -p -u -r1.14 nm-linux.h --- config/ia64/nm-linux.h 22 Aug 2004 16:32:35 -0000 1.14 +++ config/ia64/nm-linux.h 13 Sep 2004 14:04:29 -0000 @@ -45,8 +45,6 @@ extern int ia64_cannot_store_register (i /* Hardware watchpoints */ -#define TARGET_HAS_HARDWARE_WATCHPOINTS - #define TARGET_CAN_USE_HARDWARE_WATCHPOINT(type, cnt, ot) 1 /* The IA-64 architecture can step over a watch point (without triggering Index: config/pa/nm-hppah.h =================================================================== RCS file: /cvs/src/src/gdb/config/pa/nm-hppah.h,v retrieving revision 1.21 diff -p -u -r1.21 nm-hppah.h --- config/pa/nm-hppah.h 11 Aug 2004 21:51:28 -0000 1.21 +++ config/pa/nm-hppah.h 13 Sep 2004 14:04:29 -0000 @@ -98,8 +98,6 @@ extern int hppa_require_detach (int, int 10.20 will at least link. However, the "can I use a fast watchpoint?" query will always return "No" for 10.20. */ -#define TARGET_HAS_HARDWARE_WATCHPOINTS - /* The PA can watch any number of locations (generic routines already check that all intermediates are in watchable memory locations). */ extern int hppa_can_use_hw_watchpoint (int type, int cnt, int ot); Index: config/s390/nm-linux.h =================================================================== RCS file: /cvs/src/src/gdb/config/s390/nm-linux.h,v retrieving revision 1.10 diff -p -u -r1.10 nm-linux.h --- config/s390/nm-linux.h 18 Feb 2004 20:09:48 -0000 1.10 +++ config/s390/nm-linux.h 13 Sep 2004 14:04:29 -0000 @@ -45,7 +45,6 @@ extern int s390_stopped_by_watchpoint (v extern int s390_insert_watchpoint (CORE_ADDR addr, int len); extern int s390_remove_watchpoint (CORE_ADDR addr, int len); -#define TARGET_HAS_HARDWARE_WATCHPOINTS #define TARGET_CAN_USE_HARDWARE_WATCHPOINT(type, cnt, ot) 1 #define TARGET_REGION_OK_FOR_HW_WATCHPOINT(addr, len) 1 #define HAVE_CONTINUABLE_WATCHPOINT 1 --------------000908070209060702050401--